Skip to content

Commit

Permalink
Merge pull request #2062 from jesdaigle/remove-IE-support
Browse files Browse the repository at this point in the history
* remove IE references

* Remove try/catch for constructible events

* Remove unneeded reference to Firefox

Co-authored-by: Simon Pieters <[email protected]>
  • Loading branch information
jesdaigle and zcorpan authored Oct 29, 2021
1 parent c9ecd4a commit b62ebaf
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 18 deletions.
2 changes: 1 addition & 1 deletion aria-practices-DeletedSectionsArchive.html
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ <h4>Keyboard Interaction</h4>
<ul>
<li>Posts the Popup Help widget. </li>
<li>Input focus is placed on the first interactive element in the Popup Help. </li>
<li class="note">Control F1 is used by IE to "Display a help dialog box". In IE7 and IE8 <code>event.cancelBubble=true;</code> and <code>event.returnValue=false;</code> will allow the re-purposing of keys used by the browser. In the case of IE6, you can not stop the bubble up of keys used by the browser, but can stop the bubble up to the OS. In the case of Firefox and other standard compliant browsers, <code>event.stopPropagation();</code> and <code>event.preventDefault();</code> will re-purpose the keys. </li>
<li class="note"><code>event.stopPropagation();</code> and <code>event.preventDefault();</code> will re-purpose the keys. </li>
<li class="note">With the exception of Control F1 to bring up Popup Help this widget is very similar to <a href="#dialog_modal">Dialog (Modal)</a> and/or <a href="#dialog_nonmodal">Dialog (Non-Modal)</a> and/or <a href="#dialog_tooltip">Dialog (tooltip)</a> described elsewhere in this document. </li>
</ul>
</li>
Expand Down
6 changes: 3 additions & 3 deletions common/css/slices.css
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ div.slices_footer {
}
* html .slices_skipnav {
display: block
} /*Switch on for IE6 and below*/
}
*+html .slices_skipnav {
display: block
} /*Switch on for IE7*/
}
:root .slices_skipnav {
display: block
} /*Switch on for Moz, FF and Safari*/
Expand Down Expand Up @@ -111,7 +111,7 @@ div.slices_footer {
border: solid #777 2px;
color: #fff;
background: #333 !important
} /*Note IE bug that requires use of :active to mimic effect of :focus*/
}
.slices_skipnav a:hover {
cursor: default
}
Expand Down
1 change: 0 additions & 1 deletion examples/treegrid/js/treegrid-1.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ function TreeGrid(treegridElem, doAllowRowFocus, doStartRowFocus) {

// Add tabindex="0" to first row, "-1" to other rows
// We will use the roving tabindex method since aria-activedescendant
// does not work in IE
var rows = getAllRows();
var index = rows.length;
var startRowIndex = doStartRowFocus ? 0 : -1;
Expand Down
18 changes: 5 additions & 13 deletions examples/treeview/treeview-1/js/treeitem.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,19 +135,11 @@ Treeitem.prototype.handleKeydown = function (event) {
case this.keyCode.RETURN:
// Create simulated mouse event to mimic the behavior of ATs
// and let the event handler handleClick do the housekeeping.
try {
clickEvent = new MouseEvent('click', {
view: window,
bubbles: true,
cancelable: true,
});
} catch (err) {
if (document.createEvent) {
// DOM Level 3 for IE 9+
clickEvent = document.createEvent('MouseEvents');
clickEvent.initEvent('click', true, true);
}
}
clickEvent = new MouseEvent('click', {
view: window,
bubbles: true,
cancelable: true,
});
tgt.dispatchEvent(clickEvent);
flag = true;
break;
Expand Down

0 comments on commit b62ebaf

Please sign in to comment.