Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datepicker dialog example should not show disabled dates #1121

Closed
jongund opened this issue Aug 7, 2019 · 3 comments
Closed

datepicker dialog example should not show disabled dates #1121

jongund opened this issue Aug 7, 2019 · 3 comments
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Milestone
1.2 Third Working...

Comments

@jongund
Copy link
Contributor

jongund commented Aug 7, 2019 •
edited by mcking65
Loading

There are days in the first and last row of the calendar grid that are from the previous or next month. They are disabled for keyboard users. When clicked, they change the calendar to the previous or next month. Some users find this surprising behavior.

There has been discussion of having a click choose the date. But, those days are reported to screen reader users as disabled in reading mode, so making them clickable is not appropriate; they are disabled only for keyboard users.

The resolution the task force agreed upon is to remove those dates from the grid. All days in the grid will be in the month named in the dialog title. This is consistent with many date pickers found on production sites for hotels, airlines, etc.
@jongund jongund mentioned this issue Aug 27, 2019
Merged
mcking65 pushed a commit that referenced this issue Aug 28, 2019
@jongund @mcking65
Date Picker Dialog Example: hide dates from prior or next month (pull #…
e653a7a 
…1122)

Dates at the beginning and end of the grid that are for days in the prior or next month were displayed and disabled.
To resolve issue #1121, this commit removes those dates from the grid.
It also removes aria-selected from the button representing the date currently displayed in the edit field because aria-selected is not valid on button.
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Aug 28, 2019
@mcking65 mcking65 added this to the 1.2 Third Working Draft milestone Aug 28, 2019
@mcking65
Copy link
Contributor

Resolved by commit e653a7a. Many thanks to @jongund!

michael-n-cooper pushed a commit that referenced this issue Aug 28, 2019
Generated by TRAVIS-CI e653a7a
55da753 
Date Picker Dialog Example: hide dates from prior or next month (pull #1122)

Dates at the beginning and end of the grid that are for days in the prior or next month were displayed and disabled.
To resolve issue #1121, this commit removes those dates from the grid.
It also removes aria-selected from the button representing the date currently displayed in the edit field because aria-selected is not valid on button.
@Rasubra8
Copy link

What would be the acceptable behaviour when there are disabled dates or unavailable dates like holidays in between? Can such dates receive arrow key focus? Especially If not the screen reader users may not be aware of their existence/status.

@JAWS-test
Copy link

@Rasubra8: See https://www.w3.org/TR/wai-aria-practices-1.2/#kbd_disabled_controls

I think disabled dates should be able to get focus and be marked with disabled or aria-disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
Date Picker Pattern and Examples Development Project
Status: Complete
Milestone
1.2 Third Working Draft
Development

No branches or pull requests
4 participants
@jongund @mcking65 @Rasubra8 @JAWS-test