Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu or Menu bar Examples: Remove version where ARIA attributes were added dynamically by JS #443

Closed
LaurenceRLewis opened this issue Aug 11, 2017 · 1 comment
Closed

Menu or Menu bar Examples: Remove version where ARIA attributes were added dynamically by JS #443

LaurenceRLewis opened this issue Aug 11, 2017 · 1 comment
Labels
Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force
Milestone
1.1 APG Release 1

Comments

@LaurenceRLewis
Copy link

LaurenceRLewis commented Aug 11, 2017 •
edited by ZoeBijl
Loading

The two example blocks of code on the site for 'Example 1: Menubar With ARIA Markup in the HTML Source' and 'Example 2: ARIA markup added dynamically' are the same. This may confuse some who copy the example code from the page directly. Would it not be better for Example 2 code to not include the elements which are added dynamically?

For example:

<ul id="menubar2">
          <li>
            <a href="#">Research</a>
            <ul>
              <li>
                <a href="mb-research.html#res-news">Research News</a>
              </li>
              <li>
                <a href="mb-research.html#res-centers">Reseach Centers</a>
              </li>
              <li>
                <a href="mb-research.html#res-find">Find an Expert</a>
              </li>
              <li>
                <a href="mb-research.html#res-park">Research Park</a>
              </li>
              <li>
                <a href="mb-research.html#res-comm">Technology Commercialization</a>
              </li>
            </ul>
          </li>
          <li>
            <a href="#">Outreach</a>

Cheers
Laurence
mcking65 pushed a commit that referenced this issue Aug 28, 2017
@jongund @mcking65
Navigation Menubar Example: Remove second example with dynamically ad…
0300f09 
…ded ARIA attributes (pull #435)

To address issue #443, removed the second example where markup was being added dynamically, removed unnecessary js,  and fixed a bug in the HTML source code display.

Related to issue #410.
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force labels Nov 17, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 1 milestone Nov 17, 2017
@mcking65
Copy link
Contributor

Removed second example with commit 0300f09. Closing. Feel free to re-open if this does not adequately address the issue.

@mcking65 mcking65 changed the title Observation - 2.16 Menu or Menu bar Examples Menu or Menu bar Examples: Remove version where ARIA attributes were added dynamically by JS Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
1.1 APG Release 1
Development

No branches or pull requests
2 participants
@LaurenceRLewis @mcking65