Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In ARIA 1.1 Combobox with Grid Popup, Left and Right Arrow do not wrap to previous/next row in grid popup. #499

Closed
mcking65 opened this issue Oct 27, 2017 · 4 comments
Closed

In ARIA 1.1 Combobox with Grid Popup, Left and Right Arrow do not wrap to previous/next row in grid popup. #499

mcking65 opened this issue Oct 27, 2017 · 4 comments
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Milestone
1.1 APG Release 1

Comments

@mcking65
Copy link
Contributor

In the ARIA 1.1 Combobox with Grid Popup , when focus is in the grid popup, left and right arrow do not follow the grid pattern.

The focus is staying in one row and wrapping back and forth in the same row. The expectation is that focus either keeps moving through the grid to the previous or next row when the end of a row is reached or focus does not wrap.
@mcking65 mcking65 mentioned this issue Oct 27, 2017
Closed
4 tasks
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Oct 27, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 1 milestone Oct 27, 2017
@gerardkcohen
Copy link
Contributor

@mcking65 I can take this if you want

@mcking65
Copy link
Contributor Author

mcking65 commented Nov 8, 2017

@gerardkcohen, sure, that would be very helpful.

@gerardkcohen
Copy link
Contributor

@mcking65 Fixed with #530

mcking65 pushed a commit that referenced this issue Nov 20, 2017
@gerardkcohen @mcking65
Combobox with Grid Popup Example: Fix arrow key wrapping in grid (pull …
691269e 
…#530)

For issue #499, add additional check for row index so that LEFT/RIGHT arrow keys wrap to previous/next row.
@mcking65
Copy link
Contributor Author

@gerardkcohen, thank you! With commit 691269e, this is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Milestone
1.1 APG Release 1
Development

No branches or pull requests
2 participants
@gerardkcohen @mcking65