Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment is canceled because Regression Tests Coverage Report job fails #992

Closed
zcorpan opened this issue Feb 25, 2019 · 2 comments
Closed

Deployment is canceled because Regression Tests Coverage Report job fails #992

zcorpan opened this issue Feb 25, 2019 · 2 comments
Labels
bug Code defects; not for inaccurate prose Build Process Related to build process automation, including build scripts, linting, syntax automated tests, etc.
Milestone
1.1 APG Release 4

Comments

@zcorpan
Copy link
Member

zcorpan commented Feb 25, 2019

Master has not been deployed since ca78f0a (15 Jan) - the next commit a161bc6 started failing the Regression Tests Coverage Report job. I believe #965 tracks this. The result is that http://w3c.github.io/aria-practices/ is missing changes (I noticed this because I found a broken link, which has been fixed in master).

See https://github.com/w3c/aria-practices/runs/50007038 for the Travis CI result of the change that regressed the build status.

Do we want to mark this job as allowed to fail?

Further, do we want to block merging PRs to master when checks have failed? This can be done in the project's settings (under Branches).
@sh0ji sh0ji mentioned this issue Feb 26, 2019
Merged
mcking65 pushed a commit that referenced this issue Feb 27, 2019
@sh0ji @mcking65
Travis CI: Enable deploy to continue when tests we consider informati…
089049b 
…onal fail (pull #993)

To address issue #992, In .travis.yml:
* add initial allow_failures flag and apply it to regression test coverage report job.
* only set environment variables where necessary.
* reorganize jobs for readability.
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Build Process Related to build process automation, including build scripts, linting, syntax automated tests, etc. labels Feb 27, 2019
@mcking65 mcking65 added this to the 1.1 APG Release 4 milestone Feb 27, 2019
michael-n-cooper pushed a commit that referenced this issue Feb 27, 2019
Generated by TRAVIS-CI 089049b
f14e0be 
Travis CI: Enable deploy to continue when tests we consider informational fail (pull #993)

To address issue #992, In .travis.yml:
* add initial allow_failures flag and apply it to regression test coverage report job.
* only set environment variables where necessary.
* reorganize jobs for readability.
@mcking65
Copy link
Contributor

@zcorpan commented:

Further, do we want to block merging PRs to master when checks have failed? This can be done in the project's settings (under Branches).

I have enough confidence in our process now, especially with the fix in #993 that I agree this is a good idea. I'll ask Michael to make the change.

@zcorpan
Copy link
Member Author

zcorpan commented Jun 27, 2019

I believe this was fixed back in February.

@zcorpan zcorpan closed this as completed Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code defects; not for inaccurate prose Build Process Related to build process automation, including build scripts, linting, syntax automated tests, etc.
Projects
None yet
Milestone
1.1 APG Release 4
Development

No branches or pull requests
2 participants
@zcorpan @mcking65