Finish tests for dialog datepicker and fix bugs #1096
Conversation
test/tests/datepicker-dialog.js
Outdated
| 'After selected next month button, then next year button date, then previous month button, then previous year button, date should be ' + day.toISOString().split('T')[0] + ' but found: ' + dayInFocus | ||
| ); | ||
|
|
||
| // TODO: Test SPACE |
There was a problem hiding this comment.
Is it better to do t.skip instead of a comment? Or does that cause weirdness with the coverage scripts
There was a problem hiding this comment.
Oh, I see there actually is a todo https://github.com/avajs/ava/blob/master/docs/01-writing-tests.md#test-placeholders-todo
There was a problem hiding this comment.
Hmm I dug into it more yesterday thinking it might have been a webdriver bug (because I couldn't replicate it) -- but then I realized it's a firefox only bug. I added a commit with the failing tests and made a issue: #1098
|
If I did this correctly, the changes in this PR are now in a branch named bocoup-dialog-datepicker-tests. To be sure, going to change the base branch for this PR to that branch. |
|
Interesting, Github says it is changing the base branch to bocoup-dialog-datepicker-tests but then does not do it. Maybe that means it is identical so they can't be merged. I'll just open a new PR for that branch and we can compare it to this one. |
|
Closing; changes merged in PR #1141 |
This adds the rest of the tests for the dialog datepicker.
It also fixes two tiny bugs:
2019-01-9for all of the "ninth" days of the month. This was a simple off-by-one error.There is another bug that I'll make a followup issue for related to the SPACE button -- but I can only replicate it in webdriver not manually, so it's not urgent.