Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date Picker Dialog: Remove mixed click and enter/space listeners for buttons #1313

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Date Picker Dialog: Remove mixed click and enter/space listeners for buttons #1313

merged 3 commits into from
Feb 6, 2020

Conversation

smhigley
Copy link
Contributor

@smhigley smhigley commented Jan 27, 2020 •
edited by carmacleod
Loading

sh0ji
sh0ji approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@sh0ji sh0ji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code changes are code removals so there's not a lot to review here but it looks great! Switching to a click listener makes a lot of sense.

spectranaut
spectranaut approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review: it's not necessary to write new tests or change tests for this PR.

mcking65
mcking65 approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @smhigley!

@mcking65 mcking65 changed the title Remove mixed click and enter/space listeners for buttons in datepicker Date Picker Dialog: Remove mixed click and enter/space listeners for buttons Feb 6, 2020
@mcking65 mcking65 merged commit d7ea476 into master Feb 6, 2020
@mcking65 mcking65 deleted the 1311-datepicker-keydown branch February 6, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sh0ji sh0ji sh0ji approved these changes

@mcking65 mcking65 mcking65 approved these changes

@spectranaut spectranaut spectranaut approved these changes

@jongund jongund Awaiting requested review from jongund

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firefox quirk with date picker dialog
4 participants
@smhigley @spectranaut @mcking65 @sh0ji