-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update menubar navigation example #1587
Conversation
Regression test coverage:Examples without any regression tests:
Examples missing some regression tests:
Example pages with Keyboard or Attribute table rows that do not have data-test-ids:
SUMMARY:52 example pages found. ERROR - missing tests: Please write missing tests for this report to pass. |
@mcking65 |
@jongund was able to reproduce your issues locally, but I was able to resolve the issue by rebasing. You could try this locally to see if if helps, but might put you in a "bad" state if you're not familiar with git:
You'd need to force push back the branch at the end. I can submit my end branch if you want, and just let push your updates to it if you want |
messed up synchronization of files with master, so going to start over, by deleting this branch and creating a new branch for menubar navigation updates. |
Update to menubar navigation exmaple is ready for review:
Preview Link
Changes: