Landmark Regions: Updated example pages references to latest docs #1882
Conversation
jongund
changed the title
| } | ||
| } | ||
| }; | ||
| </script> | ||
| <script type="text/javascript" src="js/SkipTo.min.js"></script> | ||
| <script type="text/javascript" src="https://cdn.disability.illinois.edu/skipto.min.js"></script> |
There was a problem hiding this comment.
Should the w3c docs have a dependency on this?
There was a problem hiding this comment.
Thank you @jongund for keeping this up to date. We clearly have an issue for the redesign project here. Because we are not using respec on these pages, we have the hard coded hrefs. We need to find a way to get rid of them in the redesign or these hrefs will need constant attention on a lot of pages.
I see an external dependency on UI CDN. Can you please remove that?
examples/landmarks/HTML5.html
Outdated
| } | ||
| } | ||
| }; | ||
| </script> | ||
| <script type="text/javascript" src="js/SkipTo.min.js"></script> | ||
| <script type="text/javascript" src="https://cdn.disability.illinois.edu/skipto.min.js"></script> |
There was a problem hiding this comment.
We shouldn't have this external dependency
examples/landmarks/at.html
Outdated
| } | ||
| } | ||
| }; | ||
| </script> | ||
| <script type="text/javascript" src="js/SkipTo.min.js"></script> | ||
| <script type="text/javascript" src="https://cdn.disability.illinois.edu/skipto.min.js"></script> |
There was a problem hiding this comment.
Same issue with external dependency on UI CDN
|
@a11ydoer please review the visual aspects of this PR, especially screen shots. |
|
@mcking65 This is ready for merge. |
… update-landmarks
|
@mcking65 |
mcking65
added
bug
Updated:
Preview link
Preview | Diff