Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Fix color contrast failure in HTML source display #2939

Merged
merged 4 commits into from
Apr 7, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update highlightjs to latest version and replace references to highli…
…ght.pack.js
evmiguel committed Feb 29, 2024
commit 5ae10bb3f2004ba4c08fbedd6828131788d648b7
2 changes: 1 addition & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
**/*.min.js
common/
content/patterns/landmarks/examples/js/visua11y.js
content/shared/js/highlight.pack.js
content/shared/js/highlight.min.js
content/shared/js/skipto.js
2 changes: 1 addition & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -11,5 +11,5 @@ bootstrap-theme.css
# Ignore third party JavaScript
**/*.min.js
content/patterns/landmarks/examples/js/visua11y.js
content/shared/js/highlight.pack.js
content/shared/js/highlight.min.js
content/shared/js/skipto.js
2 changes: 1 addition & 1 deletion content-templates/Example-Template.html
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
<link rel="stylesheet" href="https://www.w3.org/StyleSheets/TR/2016/base.css">
<link rel="stylesheet" href="../../../shared/css/core.css">
<script src="../../../shared/js/examples.js"></script>
<script src="../../../shared/js/highlight.pack.js"></script>
<script src="../../../shared/js/highlight.min.js"></script>
<script src="../../../shared/js/app.js"></script>
<script src="../../../shared/js/skipto.js"></script>

337 changes: 337 additions & 0 deletions content/shared/js/highlight.min.js

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions content/shared/js/highlight.pack.js

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/coverage-report.js
Original file line number Diff line number Diff line change
@@ -473,7 +473,7 @@ glob
let src = scripts[i].getAttribute('src');
if (
src.indexOf('examples.js') < 0 &&
src.indexOf('highlight.pack.js') < 0 &&
src.indexOf('highlight.min.js') < 0 &&
src.indexOf('app.js') < 0
) {
console.log(' [script]: ' + src);
2 changes: 1 addition & 1 deletion scripts/coverage-report.template
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
<link rel="stylesheet" href="https://www.w3.org/StyleSheets/TR/2016/base.css">
<link rel="stylesheet" href="../../shared/css/core.css">
<script src="../../shared/js/examples.js"></script>
<script src="../../shared/js/highlight.pack.js"></script>
<script src="../../shared/js/highlight.min.js"></script>
<script src="../../shared/js/app.js"></script>
<script data-skipto="colorTheme:aria; displayOption:popup; containerElement:div" src="../../shared/js/skipto.js"></script>
<style>
2 changes: 1 addition & 1 deletion scripts/reference-tables.template
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
<link rel="stylesheet" href="https://www.w3.org/StyleSheets/TR/2016/base.css">
<link rel="stylesheet" href="../shared/css/core.css">
<script src="../shared/js/examples.js"></script>
<script src="../shared/js/highlight.pack.js"></script>
<script src="../shared/js/highlight.min.js"></script>
<script src="../shared/js/app.js"></script>
<script data-skipto="colorTheme:aria; displayOption:popup; containerElement:div" src="../shared/js/skipto.js"></script>
</head>

Unchanged files with check annotations Beta

If the scope of the header element were body, browsers would automatically treat the header as an ARIA banner,
so the header would not need the role="banner". -->
<div class="page">
<header role="banner">

Check warning on line 75 in content/patterns/treeview/examples/treeview-navigation.html

GitHub Actions / lint-html

The “banner” role is unnecessary for element “header”.

Check warning on line 75 in content/patterns/treeview/examples/treeview-navigation.html

GitHub Actions / lint-html

The “banner” role is unnecessary for element “header”.
<div class="title" id="id_website_title">Mythical University</div>
<div class="tagline">Using a Tree widget pattern for navigation links</div>
</header>
<!-- NOTE: In a real website the following SECTION element should be MAIN element -->
<section class="main" aria-labelledby="id_website_title id_page_title">
<h1 class="page_title" id="id_page_title">Mythical University</h1>

Check warning on line 296 in content/patterns/treeview/examples/treeview-navigation.html

GitHub Actions / lint-html

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).

Check warning on line 296 in content/patterns/treeview/examples/treeview-navigation.html

GitHub Actions / lint-html

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).
<div class="content">
<p></p>
</div>
<!-- NOTE: In a real website the footer element would be a top level element, i.e., it would have the body as its scope.
If the scope of the footer element were body, browsers would automatically treat the header as an ARIA contentinfo,
so the footer would not need the role="contentinfo". -->
<footer role="contentinfo">Mythical University footer information</footer>

Check warning on line 305 in content/patterns/treeview/examples/treeview-navigation.html

GitHub Actions / lint-html

The “contentinfo” role is unnecessary for element “footer”.

Check warning on line 305 in content/patterns/treeview/examples/treeview-navigation.html

GitHub Actions / lint-html

The “contentinfo” role is unnecessary for element “footer”.
</div>
</div>
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="End of"></div>
<!-- NOTE: In an actual website, the header element would be a top level element, i.e., it would have the body as its scope.
If the scope of the header element were body, browsers would automatically treat the header as an ARIA banner,
so the header would not need the role="banner". -->
<header role="banner">

Check warning on line 69 in content/patterns/menubar/examples/menubar-navigation.html

GitHub Actions / lint-html

The “banner” role is unnecessary for element “header”.

Check warning on line 69 in content/patterns/menubar/examples/menubar-navigation.html

GitHub Actions / lint-html

The “banner” role is unnecessary for element “header”.
<div class="title">Mythical University</div>
<div class="tagline">Using a Menubar for navigation links</div>
</header>
<!-- NOTE: The following SECTION element would be a MAIN element in an actual website -->
<div class="main">
<section aria-labelledby="id-page-title">
<h1 id="id-page-title" class="page_title">Mythical University</h1>

Check warning on line 217 in content/patterns/menubar/examples/menubar-navigation.html

GitHub Actions / lint-html

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).

Check warning on line 217 in content/patterns/menubar/examples/menubar-navigation.html

GitHub Actions / lint-html

Consider using the “h1” element as a top-level heading only (all “h1” elements are treated as top-level headings by many screen readers and other tools).
<div class="content">
<p></p>
</div>
NOTE: In an actual website, the footer element would be a top level element, i.e., it would have the body as its scope.
If the scope of the footer element were body, browsers would automatically treat the footer as an ARIA contentinfo landmark, so the footer would not need the role="contentinfo".
-->
<footer role="contentinfo">Mythical University footer information</footer>

Check warning on line 227 in content/patterns/menubar/examples/menubar-navigation.html

GitHub Actions / lint-html

The “contentinfo” role is unnecessary for element “footer”.

Check warning on line 227 in content/patterns/menubar/examples/menubar-navigation.html

GitHub Actions / lint-html

The “contentinfo” role is unnecessary for element “footer”.
</div>
</div>
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="End of"></div>