Infrastructure: Exclude skipto.js in coverage-report.js and report accurate values in Coverage and Quality Reports
#3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
changed the title
skipto.js during npm run coverage-reportskipto.js in coverage-report.js and report accurate values in Coverage and Quality Reports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #3000 (comment), found that values under the Coding Summary, Coding Practices and Mouse and Pointer Events of the Coverage and Quality Reports page were being significantly and inaccurately increased.
That's because of the
skipto.jsutility included in each pattern's html file was not being ignored in thecoverage-report.jsscript and was adding to the metrics when the *.js files were being evaluated.WAI Preview Link (Last built on Thu, 23 May 2024 12:59:46 GMT).