Add redesigned toolbar example #950
Conversation
| @@ -30,7 +30,7 @@ module.exports = async function assertRovingTabindex (t, elementsSelector, key) | |||
| assert.equal( | |||
| await elements[el].getAttribute('tabindex'), | |||
| tabindex, | |||
| 'focus is on element ' + tabableEl + ' of elements "' + elementsSelector + | |||
| 'focus is on element ' + tabableEl + ' of ' + elements.length + ' elements "' + elementsSelector + | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Need to determine if the change on line 33 to test/util/assertRovingTabindex.js should be included.
After that change was made, I made commit 38a5619, which included changes to the same file made by Valerie. My question is whether @jongund would have made changes to this file if I would have merged those changes from Valerie before he began work on the toolbar tests. In other words, I may have caused some unnecessary headaches by forgetting that we had some work from Valerie that was still not in master.
examples/toolbar/toolbar.html
Outdated
| that demonstrates how a toolbar can group a set of buttons into a single tab stop. | ||
| It also illustrates the roving tabindex method for managing focus within a component. | ||
| and demonstrates how a toolbar can group a set of interactive widgets into a single tab stop. | ||
| For illustrative and interoperability assessment purposes, this This implementation includes a diverse set of widgets, some of which may not be ordinarily grouped in the same toolbar. |
There was a problem hiding this comment.
| For illustrative and interoperability assessment purposes, this This implementation includes a diverse set of widgets, some of which may not be ordinarily grouped in the same toolbar. | |
| For illustrative and interoperability assessment purposes, this implementation includes a diverse set of widgets, some of which may not be ordinarily grouped in the same toolbar. |
|
Just something minor. It looks like there is a typo in the intro text. The text is as follows currently " For illustrative and interoperability assessment purposes, this This implementation includes a diverse set of widgets, some of which may not be ordinarily grouped in the same toolbar" |
|
Mark and Curt have already commented on the only issue I observed. Otherwise looks good. |
|
Merging as discussed in today's meeting. The missing regression tests are tracked separately in issue #965. |
The toolbar example is now redesigned and rebuilt to resolve issues listed in issue #539. It is now ready for final review prior to publication in APG R3.
Link to Test Page
Toolbar in feature branch issue541-toolbar-redesign