-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar Example: Add missing descriptive tooltips #986 fix #998
Conversation
I'll get a reviewer assigned today. Question about changes starting at line 213, are they white space changes only? The replacement line sounds the same as the original to me. |
yes at line 213 onwards, it is white space changes only |
@ardnahcivar @mcking65 |
@jongund , any pointers, sugesstions how to fix it |
Hi, @ardnahcivar! Thank-you so much for your pull request! The group discussed this yesterday, and we decided that we prefer not to use the The W3C HTML spec for the title attribute mentions this:
We believe the direction should be similar to @ZoeBijl's example tooltip with aria-labelledby (in CodePen). Do you want to have a go at writing this for the toolbar example? |
@mcking65 Is this pull request going to be merged soon? |
@ardnahcivar, sorry we chose another path, which @jongund implemented in #1069. Closing this PR. If you are available for other bugs, please comment in the relevant issue so we can talk about the approach to resolution. We don't want people to get discouraged from contributing because of situations like this where they offer some work and then we re-do it or go down another path. |
added the descriptive title for the toolbar buttons.