Editorial: clarify expectations for name/desc verbosity #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #1649 These editorial changes attempt to clarify that a description _doesn't have to be verbose_. It also adjusts some wording so when talking about an accessible name, the spec is saying that, and not using the term "label" This update touches `aria-labelledby` and `aria-describedby` - because they share the same paragraph between the two. It also touches `aria-description` which also was semi-reusing the paragraph that was repeated between `aria-labelledby` and `aria-describedby` - but it also needed a few wording changes. Happy for others to add onto this or make further wording adjustments as need be.
jnurthen
approved these changes
Nov 24, 2021
scottaohara
commented
Nov 26, 2021
pkra
approved these changes
Dec 3, 2021
pkra
added
the
editorial
|
@jnurthen @michael-n-cooper What is the process to update the stable branch? Do I simply cherry pick the merged commit and push it to stable? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1649
These editorial changes attempt to clarify that a description doesn't have to be verbose.
It also adjusts some wording so when talking about an accessible name, the spec is saying that, and not using the term "label"
This update touches
aria-labelledbyandaria-describedby- because they share the same paragraph between the two. It also touchesaria-descriptionwhich also was semi-reusing the paragraph that was repeated betweenaria-labelledbyandaria-describedby- but it also needed a few wording changes.Happy for others to add onto this or make further wording adjustments as need be.
Preview | Diff