-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
associationlist and related roles have tediously long names #1740
Conversation
@@ -4588,6 +4410,7 @@ <h5>Note regarding the ARIA 1.3 <code>image</code> role.</h5> | |||
<ul> | |||
<li><code><ol></code> in [[HTML]]</li> | |||
<li><code><ul></code> in [[HTML]]</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth adding in <menu>
here as part of this pr? or want me to create a separate PR just for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have never seen menu used anywhere so not sure I see the benefit of adding it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merely to be complete, since the spec lists 3 of the 4 related elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes the spec any more understandable though as most devs would probably mistake the menu element for something useful
<p>Author requirements for <a>elements</a> whose <a>role</a> is <code>listitemkey</code>:</p> | ||
<ul> | ||
<li>MUST be contained in an element whose <a>role</a> is <rref>list</rref>.</li> | ||
<li>SHOULD be followed by one or more sibling <a>elements</a> whose <a>role</a> is <rref>listitemvalue</rref>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably mention here that there should (must?) be no intervening listitem
elements that interrupt the expected sibling relationship to the listitemkey/listitemvalue
|
||
<p>Author requirements for <a>elements</a> whose <a>role</a> is <code>listitemvalue</code>:</p> | ||
<ul> | ||
<li>MUST be contained in an element whose <a>role</a> is <rref>list</rref>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repeat of previous comment:
we should probably mention here that there should (must?) be no intervening listitem elements that interrupt the expected sibling relationship to the listitemkey/listitemvalue
<p>Author requirements for <a>elements</a> whose <a>role</a> is <code>listitemvalue</code>:</p> | ||
<ul> | ||
<li>MUST be contained in an element whose <a>role</a> is <rref>list</rref>.</li> | ||
<li>SHOULD have a preceding sibling <a>element</a> whose <a>role</a> is <rref>listitemkey</rref>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be "MUST be either listitemkey or listitemvalue and the "first/eldest" sibling MUST be listitemkey".
Does "sibling" refer to the accessibility tree?
Overcome by events leading to #2095 |
Fixes #1662
💥 Error: 504 Gateway Time-out 💥
PR Preview failed to build. (Last tried on May 11, 2022, 5:04 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.