Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

associationlist and related roles have tediously long names #1740

Closed
wants to merge 2 commits into from

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented May 11, 2022

Fixes #1662


💥 Error: 504 Gateway Time-out 💥

PR Preview failed to build. (Last tried on May 11, 2022, 5:04 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

<html><body><h1>504 Gateway Time-out</h1>
The server didn't respond in time.
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@@ -4588,6 +4410,7 @@ <h5>Note regarding the ARIA 1.3 <code>image</code> role.</h5>
<ul>
<li><code>&lt;ol&gt;</code> in [[HTML]]</li>
<li><code>&lt;ul&gt;</code> in [[HTML]]</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding in <menu> here as part of this pr? or want me to create a separate PR just for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never seen menu used anywhere so not sure I see the benefit of adding it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merely to be complete, since the spec lists 3 of the 4 related elements.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes the spec any more understandable though as most devs would probably mistake the menu element for something useful

<p>Author requirements for <a>elements</a> whose <a>role</a> is <code>listitemkey</code>:</p>
<ul>
<li>MUST be contained in an element whose <a>role</a> is <rref>list</rref>.</li>
<li>SHOULD be followed by one or more sibling <a>elements</a> whose <a>role</a> is <rref>listitemvalue</rref>.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably mention here that there should (must?) be no intervening listitem elements that interrupt the expected sibling relationship to the listitemkey/listitemvalue

index.html Outdated Show resolved Hide resolved

<p>Author requirements for <a>elements</a> whose <a>role</a> is <code>listitemvalue</code>:</p>
<ul>
<li>MUST be contained in an element whose <a>role</a> is <rref>list</rref>.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repeat of previous comment:
we should probably mention here that there should (must?) be no intervening listitem elements that interrupt the expected sibling relationship to the listitemkey/listitemvalue

index.html Outdated Show resolved Hide resolved
<p>Author requirements for <a>elements</a> whose <a>role</a> is <code>listitemvalue</code>:</p>
<ul>
<li>MUST be contained in an element whose <a>role</a> is <rref>list</rref>.</li>
<li>SHOULD have a preceding sibling <a>element</a> whose <a>role</a> is <rref>listitemkey</rref>.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be "MUST be either listitemkey or listitemvalue and the "first/eldest" sibling MUST be listitemkey".

Does "sibling" refer to the accessibility tree?

@pkra pkra added this to the ARIA 1.3 milestone Jun 28, 2023
@pkra
Copy link
Member

pkra commented Feb 7, 2024

Overcome by events leading to #2095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Scott O'Hara
Development

Successfully merging this pull request may close these issues.

associationlist and related roles have tediously long names
3 participants