-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editorial: revise custom stylesheets #2410
Draft
pkra
wants to merge
7
commits into
main
Choose a base branch
from
issue2226
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+5
−343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unused and commented-out styles as per #2226 (comment)
pkra
added
editorial
a change to an example, note, spelling, grammar, or is related to publishing or the repo
Agenda-Editors
labels
Jan 9, 2025
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
notes to self:
|
Removes unused and commented-out styles as per #2226 (comment)
- aria spec - rewrite content model figure to actual figure, using respec features - common.css: remove .image and . img-caption
It turns out, core-aam only sets styling that are already set in common.css. |
- remove core-aam.css - all styling is done identically in common.css - core-aam/index.html - removes link to core-aam.css
Stylesheet was removed as all styling is done identically in common.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Agenda-Editors
editorial
a change to an example, note, spelling, grammar, or is related to publishing or the repo
spec:aria
spec:core-aam
spec:html-aam
spec:pdf-aam
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2226
table.def
from w3.org/StyleSheets/TR/2021/base.css (i.e., remove our custom styles and replace table classes with.def
)th{ background-color:#eee; }
(cf. Text-to-background contrast in tables under ARIA's Definition of Roles too low #2394 + duplicates)#example-48
=> https://github.com/speced/respec/wiki/ReSpec-Editor's-Guide#examplesPreview | Diff