Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '[SecureContext]` tags to the interface #68

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Feb 5, 2024

w3c/webref repo automatically extracts syntaxes from these spec docs. At the moment some syntax sections are missing the [SecureContext] tags so it is missing from extracted data in webref as well.

The feature has been marked available in secure context in MDN docs.

The PR adds the tags to the ContactAddress interface.


Preview | Diff

index.bs Outdated Show resolved Hide resolved
@marcoscaceres
Copy link
Member

Yeah, this seems like an oversight. @beverloo ?

@marcoscaceres
Copy link
Member

@w3cbot
Copy link

w3cbot commented Feb 7, 2024

marcoscaceres marked as non substantive for IPR from ash-nazg.

@marcoscaceres
Copy link
Member

@OnkarRuikar, please make sure you fix the bug in your script for adding SecureContext to partial interfaces ... that's going to break a lot of specs if people merge those PRs. I think Webidl2.js might catch those, but I don't know about BikeShed.

@marcoscaceres
Copy link
Member

PS, @OnkarRuikar, the commit message should be "Add [SecureContext] extended attribute to X interface" or similar.

@marcoscaceres marcoscaceres merged commit 2c6c63d into w3c:main Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants