-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test-suite errors #2194
Comments
(click on each image for the larger view) |
Just, to look at the mailing list issue for a moment--to subscribe (this is not super obvious) to [email protected] you have to send a mail with the subject “subscribe” to the address But filing here is fine. @plinss is in charge of the harness, though, so I can't help you with fixing the actual problem. :) |
The base problem is with the style-change.js file, it needs to be in a support directory that is in the same directory as the test, so the script tag should have a src="support/style-change.js" rather than "../support/style-change.js". This is a known limitation of the build system, as the directory structure of the test suite gets flattened. I do need to update the "Report Issue" button to no longer point to Shepherd |
This should fix w3c/csswg-drafts#2194 as it's moving the style-change.js script under css/css-grid/alignment/support/ folder. On top of that it's fixing those tests as the second checkLayout() call was never checked. This was because by default checkLayout() calls done(), and the test thinks it has already finished. Modified the call to checkLayout() in the script style-change.js and calling manually done() in the tests fixes the problem.
One other error in the Chrome console: eg at |
Thanks for looking into / fixing these issues! Another one: eg at http://test.csswg.org/harness/test/css-grid-1_dev/grid-alignment-implies-size-change-011/ : |
More issues detected on w3c/csswg-drafts#2194. This time it's fixing the relative path to an image. The patch copies the 100x100-green.png file under the relative support/ folder and modifies the paths to it in the tests.
I've fixed the issue with the image, it was again a problem with the Regarding the JavaScript console error I don't know what it's but I don't see it in http://w3c-test.org/css/css-grid/alignment/grid-alignment-implies-size-change-001.html |
The JS error at test.csswg.org/harness/test/css-grid-1_dev/grid-alignment-implies-size-change-019/ is gone (probably since the path to the .js got fixed). |
The CSP error is the result of some experimental code in the framework that the harness is built on. It's set to report-only so doesn't affect the behavior of the browser. There's no report-uri because we don't need one yet (no point in reporting against an unfinished CSP policy). Chrome is just warning that the CSP heading isn't doing anything useful. |
Filing this here because time doesn't allow me to be subscribed to [email protected] .
Screenshots:
The text was updated successfully, but these errors were encountered: