Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scroll-animations-1] Are timeline names tree-scoped? #8135

Closed
andruud opened this issue Nov 28, 2022 · 4 comments
Closed

[scroll-animations-1] Are timeline names tree-scoped? #8135

andruud opened this issue Nov 28, 2022 · 4 comments
Labels
scroll-animations-1 Current Work

Comments

@andruud
Copy link
Member

andruud commented Nov 28, 2022

I initially thought "yes", but then https://drafts.csswg.org/css-scoping/#shadow-names seemed to only apply to "global names" (i.e. names created by at-rules), which is not quite the case for scroll timeline names.

There's a discussion in #7916 in relation to anchor/CQ names, which seems to expect that names (also non-"global" names) are tree-scoped by default?

Either way, it would be good to state it explicitly.
@andruud andruud added the scroll-animations-1 Current Work label Nov 28, 2022
@fantasai
Copy link
Collaborator

fantasai commented Dec 7, 2022

Last time we discussed it, we decided that timeline names would be scoped across the flattened tree: see minutes

Lmk if you think we should reconsider for some reason

Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 16, 2023
@andruud @chromium-wpt-export-bot
[scroll-timeline] Hide support for tree-scoped timeline behind a flag
c6b8e5e 
It is not clear whether or not timelines should be tree-scoped,
but the current intent is apparently that they should not [1].
We need to adjust our implementation accordingly, but to avoid
potential churn in case of a counter-resolution, we hide the
tree-scoping code behind a flag instead of removing it.

The WPTs which previously tested the tree-scoping behavior are for now
demoted to unit

[1] w3c/csswg-drafts#8135

Bug: 1382876
Change-Id: Ie3bcd5cf02da8d5bb03b838e295d4a5f5ef70c05
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 17, 2023
@andruud @chromium-wpt-export-bot
[scroll-timeline] Hide support for tree-scoped timeline behind a flag
bc18d46 
It is not clear whether or not timelines should be tree-scoped,
but the current intent is apparently that they should not [1].
We need to adjust our implementation accordingly, but to avoid
potential churn in case of a counter-resolution, we hide the
tree-scoping code behind a flag instead of removing it.

The WPTs which previously tested the tree-scoping behavior are for now
demoted to unit

[1] w3c/csswg-drafts#8135

Bug: 1382876
Change-Id: Ie3bcd5cf02da8d5bb03b838e295d4a5f5ef70c05
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 18, 2023
@andruud @chromium-wpt-export-bot
[scroll-timeline] Hide support for tree-scoped timeline behind a flag
ca5dcd5 
It is not clear whether or not timelines should be tree-scoped,
but the current intent is apparently that they should not [1].
We need to adjust our implementation accordingly, but to avoid
potential churn in case of a counter-resolution, we hide the
tree-scoping code behind a flag instead of removing it.

The WPTs which previously tested the tree-scoping behavior are for now
demoted to unit

[1] w3c/csswg-drafts#8135

Bug: 1382876
Change-Id: Ie3bcd5cf02da8d5bb03b838e295d4a5f5ef70c05
aarongable pushed a commit to chromium/chromium that referenced this issue Jan 18, 2023
@andruud
[scroll-timeline] Hide support for tree-scoped timeline behind a flag
7e9ac88 
It is not clear whether or not timelines should be tree-scoped,
but the current intent is apparently that they should not [1].
We need to adjust our implementation accordingly, but to avoid
potential churn in case of a counter-resolution, we hide the
tree-scoping code behind a flag instead of removing it.

The WPTs which previously tested the tree-scoping behavior are for now
demoted to unit

[1] w3c/csswg-drafts#8135

Bug: 1382876
Change-Id: Ie3bcd5cf02da8d5bb03b838e295d4a5f5ef70c05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161609
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1093779}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 18, 2023
@andruud @chromium-wpt-export-bot
[scroll-timeline] Hide support for tree-scoped timeline behind a flag
ad59532 
It is not clear whether or not timelines should be tree-scoped,
but the current intent is apparently that they should not [1].
We need to adjust our implementation accordingly, but to avoid
potential churn in case of a counter-resolution, we hide the
tree-scoping code behind a flag instead of removing it.

The WPTs which previously tested the tree-scoping behavior are for now
demoted to unit

[1] w3c/csswg-drafts#8135

Bug: 1382876
Change-Id: Ie3bcd5cf02da8d5bb03b838e295d4a5f5ef70c05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161609
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1093779}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 18, 2023
@andruud @chromium-wpt-export-bot
[scroll-timeline] Hide support for tree-scoped timeline behind a flag
53f463f 
It is not clear whether or not timelines should be tree-scoped,
but the current intent is apparently that they should not [1].
We need to adjust our implementation accordingly, but to avoid
potential churn in case of a counter-resolution, we hide the
tree-scoping code behind a flag instead of removing it.

The WPTs which previously tested the tree-scoping behavior are for now
demoted to unit

[1] w3c/csswg-drafts#8135

Bug: 1382876
Change-Id: Ie3bcd5cf02da8d5bb03b838e295d4a5f5ef70c05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161609
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1093779}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 20, 2023
@andruud @moz-wptsync-bot
Bug 1810494 [wpt PR 37982] - [scroll-timeline] Hide support for tree-…
aa7e094 
…scoped timeline behind a flag, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Hide support for tree-scoped timeline behind a flag

It is not clear whether or not timelines should be tree-scoped,
but the current intent is apparently that they should not [1].
We need to adjust our implementation accordingly, but to avoid
potential churn in case of a counter-resolution, we hide the
tree-scoping code behind a flag instead of removing it.

The WPTs which previously tested the tree-scoping behavior are for now
demoted to unit

[1] w3c/csswg-drafts#8135

Bug: 1382876
Change-Id: Ie3bcd5cf02da8d5bb03b838e295d4a5f5ef70c05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161609
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1093779}

--

wpt-commits: 53f463f88eaa0f5e33c939da906abe2b1f945a99
wpt-pr: 37982
@bramus
Copy link
Contributor

bramus commented Jan 23, 2023

Discussion continued in #8192?

jamienicol pushed a commit to jamienicol/gecko that referenced this issue Jan 25, 2023
@andruud @moz-wptsync-bot
Bug 1810494 [wpt PR 37982] - [scroll-timeline] Hide support for tree-…
5e6c8cf 
…scoped timeline behind a flag, a=testonly

Automatic update from web-platform-tests
[scroll-timeline] Hide support for tree-scoped timeline behind a flag

It is not clear whether or not timelines should be tree-scoped,
but the current intent is apparently that they should not [1].
We need to adjust our implementation accordingly, but to avoid
potential churn in case of a counter-resolution, we hide the
tree-scoping code behind a flag instead of removing it.

The WPTs which previously tested the tree-scoping behavior are for now
demoted to unit

[1] w3c/csswg-drafts#8135

Bug: 1382876
Change-Id: Ie3bcd5cf02da8d5bb03b838e295d4a5f5ef70c05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161609
Commit-Queue: Anders Hartvoll Ruud <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1093779}

--

wpt-commits: 53f463f88eaa0f5e33c939da906abe2b1f945a99
wpt-pr: 37982
@flackr
Copy link
Contributor

flackr commented Jan 31, 2023

I'm not sure what to do about this issue, it seems like it was resolved in #7047 (as mentioned by @fantasai above #8135 (comment) ) and there is a separate issue as mentioned by @bramus #8135 (comment) . Do we close this and leave it to those other issues?

@andruud
Copy link
Member Author

andruud commented Feb 1, 2023

This is not the same issue as #8192. That affects anonymous timeline lookups as well (scroll()), while this does not. Not having tree-scoped timelines does not match @tabatkins' most recent thinking in #7916 in my opinion. However, if we're still sure about the #7047 decision, then I'm happy to close this issue. Tree-scoped names are painful to implement anyway.

@andruud andruud closed this as completed Feb 1, 2023
@khushalsagar khushalsagar mentioned this issue Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scroll-animations-1 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andruud @bramus @flackr @fantasai