Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-shapes-2] Specify the grammar for shape() #11207

Merged
merged 11 commits into from
Dec 10, 2024
Merged

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Nov 13, 2024

grammar changes:

  • <<position>> can be used instead of an absolute point
  • The relevant <<position>>'s dimension can be used for hline/vline
  • Since keywords define the different components, order of components is flexible
  • with is used for curve control points
  • Two curve control points are separated by /
  • Relative control points can be relative to segment-start/segment-end/reference-box, defaulting to segment start.

Resolution: #10649 (comment)

Closes #10649
Closes #10666

[css-spec-shortname-1] Brief description which should also include the #issuenum-or-URL and/or link to relevant CSSWG minutes.

Copy the above line into the Title and replace with the relevant details. Fill in any additional details here. See https://github.com/w3c/csswg-drafts/blob/master/CONTRIBUTING.md for more info.

- <<position>> can be used instead of an absolute point.
- One of a <<position>>'s dimension can be used for hline/vline
- Since keywords define the different components, order of components is flexible.

Curves:
- `with` is used for control points
- Two control points are separated by /
- Relative control points can be relative to segment-start/segment-end/reference-box

Resolution: w3c#10649 (comment)

Closes w3c#10649
Closes w3c#10666
@noamr noamr requested review from smfr, tabatkins and astearns November 13, 2024 21:38
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
Copy link
Member

@tabatkins tabatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some syntax fixes, i'll merge them myself

css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
css-shapes-2/Overview.bs Outdated Show resolved Hide resolved
@tabatkins tabatkins merged commit 8814e9e into w3c:main Dec 10, 2024
1 check passed
@tabatkins
Copy link
Member

I do wanna fiddle a little bit more with the wording about by/to and relative coords, but I can't leave suggestions when there are deleted lines in the range, annoyingly. I'll do so afterwards.

@noamr noamr deleted the shape-syntax branch December 11, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants