-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-shapes-2] Specify the grammar for shape()
#11207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- <<position>> can be used instead of an absolute point. - One of a <<position>>'s dimension can be used for hline/vline - Since keywords define the different components, order of components is flexible. Curves: - `with` is used for control points - Two control points are separated by / - Relative control points can be relative to segment-start/segment-end/reference-box Resolution: w3c#10649 (comment) Closes w3c#10649 Closes w3c#10666
smfr
reviewed
Nov 13, 2024
fantasai
reviewed
Nov 14, 2024
fantasai
reviewed
Nov 14, 2024
fantasai
reviewed
Nov 14, 2024
fantasai
reviewed
Nov 14, 2024
Co-authored-by: fantasai <[email protected]>
Co-authored-by: fantasai <[email protected]>
Co-authored-by: fantasai <[email protected]>
Co-authored-by: fantasai <[email protected]>
weinig
reviewed
Nov 16, 2024
tabatkins
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some syntax fixes, i'll merge them myself
I do wanna fiddle a little bit more with the wording about by/to and relative coords, but I can't leave suggestions when there are deleted lines in the range, annoyingly. I'll do so afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grammar changes:
<<position>>
can be used instead of an absolute point<<position>>
's dimension can be used forhline
/vline
with
is used for curve control pointsResolution: #10649 (comment)
Closes #10649
Closes #10666
[css-spec-shortname-1] Brief description which should also include the #issuenum-or-URL and/or link to relevant CSSWG minutes.
Copy the above line into the Title and replace with the relevant details. Fill in any additional details here. See https://github.com/w3c/csswg-drafts/blob/master/CONTRIBUTING.md for more info.