[css-multicol] Revert part of a change about formatting contexts #1588
Conversation
Stating that the element establishes a new formatting context, without saying what kind of formatting context it needs to establish is not specific enough. Also, saying that it must establish a "new" formatting context is ambiguous or misleading for elements that would establish one anyway. The current definition of "becomes a formatting context" is problematic (see w3c#1457), so we need to fix it, but it is precisely aimed at solving this: defining what kind of formatting context to establish for the boxes that wouldn't otherwise, and being clear about which boxes are fine as is and don't need to be changed.
|
@fantasai You have changed the commit I made to solve #1071. I disagree with (part of) your commit, but as I don't want to start an editing war where we revert each other, I've made this pull request with my fix to your fix, to be merged (or closed) once we agree. The reason for my disagreement is explained in the comment above (which is the commit message). @tabatkins, since you approved my original commit, feel free to chime in to either back me up or repent for ever thinking this was a good idea. |
|
I agree with @fantasai's revert in general - despite my original +1, the text for "becomes a formatting context" is indeed incorrect and needs fixing. I do agree that we need to link to an algo for this process, rather than just relying on "establishes a new FC", for the reasons you state. |
|
@tabatkins I'm a little confused. Are you saying that we should merge this (and link back to "becomes a formatting context") once the text for "becomes a formatting context" is fixed, or that we shouldn't link back and fix this some other way? To my feeble mind, your comment seems to implies both. |
|
Yes, it's both. Basically the text right now is bad and we should fix it, which we'll do after f2f discussion, and so there's no much reason to worry about the language right at this moment. |
|
Closing. Even if we eventually change this, it will not be via this pull request. |
Stating that the element establishes a new formatting context, without
saying what kind of formatting context it needs to establish is not
specific enough. Also, saying that it must establish a "new" formatting
context is ambiguous or misleading for elements that would establish one
anyway.
The current definition of "becomes a formatting context" is
problematic (see #1457), so we
need to fix it, but it is precisely aimed at solving this: defining what
kind of formatting context to establish for the boxes that wouldn't
otherwise, and being clear about which boxes are fine as is and don't
need to be changed.