Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-transforms-1] Fix 5520 #5702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[css-transforms-1] Fix 5520 #5702

wants to merge 1 commit into from

Conversation

mclegrand
Copy link
Member

Fixes #5520

Fixes w3c#5520 :
Order of things happening in the example was reversed
@mclegrand
Copy link
Member Author

(also fixes #4767 : bottom left → bottom right)

@svgeesus
Copy link
Contributor

Closing and re-opening to kick the IPR bot into activity

@svgeesus svgeesus closed this Jan 21, 2025
@svgeesus svgeesus reopened this Jan 21, 2025
@w3cbot
Copy link

w3cbot commented Jan 21, 2025

svgeesus marked as non substantive for IPR from ash-nazg.

@dbaron
Copy link
Member

dbaron commented Jan 21, 2025

So there's a lot going on here.

Part of what's difficult about this stuff is that it makes sense to think about most of these things in either order. You can think of the math as matrices that operate on row-vectors or matrices that operate on column-vectors. The spec is pretty consistent about using column vectors.

Likewise, you can visually think about the transforms as transforming coordinates starting from the root coordinate space and transforming your way to the leaf, or starting from the leaf element and transforming it to the root.

Every time I read anything about transforms, I have to start from first principles to figure out which way I'm looking at it. (I'm an editor of the transforms spec and I don't remember what the order of the transforms functions means; I just figure it out again every time I need to know.) Maybe that's a bad sign, though.

I haven't looked at the text diffs much yet. However, I took a look at the image diffs, and I think they're substantively incorrect, although I haven't yet thought about which way makes more sense. In particular, the image currently in the spec geometrically matches this testcase, whereas the revised image is a bit like but doesn't actually match this revised testcase. So I think even if we want to flip the logic of the image around, the new image isn't quite right.

I'll try to dig in more later and figure out whether I agree with the textual changes proposed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[css-transforms-1] Example 5 is wrong : order is reversed
4 participants