Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid-1][editorial] Rearrange the grid layout algo a little for clarity, making a new top-level algo. #3418 #9540

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

tabatkins
Copy link
Member

@fantasai and I did some editorial rearrangement, per #3418.

PR to ask for review from @Loirooriol and @mrego.

@tabatkins tabatkins marked this pull request as draft October 30, 2023 22:58
@fantasai
Copy link
Collaborator

Reminder to xcommit to css-grid-2 before merging. :)

css-grid-1/Overview.bs Outdated Show resolved Hide resolved
css-grid-1/Overview.bs Outdated Show resolved Hide resolved
@fantasai fantasai requested review from Loirooriol and mrego November 2, 2023 03:26
Copy link
Member

@mrego mrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it's been a while, but this wording seems pretty clear to me. Thanks for working on this!

@tabatkins tabatkins force-pushed the rearrange-grid-layout-algo branch from 80982de to 446ae5c Compare November 3, 2023 20:36
@tabatkins tabatkins marked this pull request as ready for review November 3, 2023 20:36
@tabatkins tabatkins merged commit 600c743 into main Nov 3, 2023
@tabatkins tabatkins deleted the rearrange-grid-layout-algo branch November 3, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants