Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 3 use of "visual.text" is not described #276

Closed
cconcolato opened this issue Dec 2, 2024 · 1 comment · Fixed by #277
Closed

Example 3 use of "visual.text" is not described #276

cconcolato opened this issue Dec 2, 2024 · 1 comment · Fixed by #277
Assignees
@nigelmegitt
Labels
editorial

Comments

@cconcolato
Copy link
Contributor

Looking at Example 3, scriptRepresents uses visual.text but no events use it. This is not wrong per se, but a) it's not documented and b) it makes it hard to understand why langSrc is empty (presumably if there was text, then there would be an inherent language).

There are 2 options:

  • remove visual.text
  • add an explanation on whyvisual.text is used
@nigelmegitt nigelmegitt self-assigned this Dec 6, 2024
nigelmegitt added a commit that referenced this issue Dec 6, 2024
@nigelmegitt
Address #276
d06bb79 
* Remove visual.text from daptm:scriptRepresents when it is not used
* Add and describe a new example demonstrating the use of content descriptor sub-type, and how langSrc is set when the transcript reflects visual text.
@nigelmegitt nigelmegitt mentioned this issue Dec 6, 2024
Merged
@nigelmegitt nigelmegitt linked a pull request Dec 6, 2024 that will close this issue
Improve Script Represents in AD examples #277
Merged
@nigelmegitt
Copy link
Contributor

Good catch!

Pull request #277 opened to address this, if you want to take a look @cconcolato .

nigelmegitt added a commit that referenced this issue Dec 10, 2024
@nigelmegitt
Address #276
a0056fa 
* Remove visual.text from daptm:scriptRepresents when it is not used
* Add and describe a new example demonstrating the use of content descriptor sub-type, and how langSrc is set when the transcript reflects visual text.
nigelmegitt added a commit that referenced this issue Dec 10, 2024
@nigelmegitt
Improve Script Represents in AD examples (#276)
d557c1f 
* Remove `visual.text` from `daptm:scriptRepresents` in examples when it is not used
* Add and describe a new example demonstrating the use of content descriptor sub-type, and how `langSrc` is set when the transcript reflects visual text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nigelmegitt nigelmegitt

Labels
editorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Script Represents in AD examples w3c/dapt
2 participants
@cconcolato @nigelmegitt