Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document fully active checks #187

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add document fully active checks #187

wants to merge 9 commits into from

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jul 4, 2024

Closes #181

The following tasks have been completed:

  • Modified Web platform tests (link to pull request)

Implementation commitment:


Preview | Diff

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@marcoscaceres marcoscaceres requested a review from reillyeon July 4, 2024 00:23
marcoscaceres and others added 2 commits July 4, 2024 10:24

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
marcoscaceres and others added 2 commits July 4, 2024 10:32
@@ -342,6 +344,8 @@ To <dfn>fire an orientation event</dfn> given a {{DOMString}} |event|, {{Window}
1. Let |state| be the result of <a>getting the current permission state</a> with |permission| and |environment|.
1. If |state| is not "{{PermissionState/granted}}", return.
1. [=Queue a global task=] on the [=device motion and orientation task source=] given |window| to run the following steps:
1. If |document| is not [=document/fully active=], return.
1. If |document|'s [=Document/visibility state=] is not "`visible`", return.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right place for this check, but we should remove the duplicate checks from "deviceorientation firing steps" below.

Co-authored-by: Reilly Grant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully active checks
2 participants