-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Representations need explicit type conversion rules #462
Comments
This is related to #456 (value space vs. lexical space). |
@jricher @msporny @peacekeeper how can I take action on this issue? feels like this is a duplicate of the concept of a "well defined" representation... if the representations production consumption rules don't solve this, how is it valid? if they do, why is this issue needed? |
It is, and I'm actively working on this issue right now -- and #361 -- the last thing that needs to be done is CBOR consumption rules (getting ready to write that PR in the next 30 minutes)... I've been getting all the other representation production/consumption rules aligned to the updated/complete ADM model that achieved consensus in the group. @OR13 I reassigned this to me, will notify in this thread when I have a PR finished for it. In summary, I expect issue #462 and issue #361 to be closed when PR #476 is merged. |
PR #476 has been merged, closing this issue. |
@msporny has the right of it, but it also needs to clearly go both ways, to and from the data model data types and the representation's data types. So you need things like this strawman:
"If you see an Integer in the ADM it goes in a JSON Number"
As well as:
"If you see a JSON Number in the representation, and don't have an additional property definition, it is an ADM Float".
I'm ok with this being in a separate PR but this can't be lost.
Originally posted by @jricher in #455 (comment)
The text was updated successfully, but these errors were encountered: