Add DID parameter entries. Fixes #32. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peacekeeper
changed the title
|
This fixes #32. |
rhiaro
approved these changes
Jun 16, 2020
Comment on lines
1719
to
1721
| <p class="issue" data-number="30"> | ||
| Example needed. | ||
| </p> |
There was a problem hiding this comment.
Suggested change
| <p class="issue" data-number="30"> | |
| Example needed. | |
| </p> |
We can close this too since we're not differentiating 'extensions' in so many words any more.
There was a problem hiding this comment.
That sounds fine, but we could also add examples of extension DID parameters later (e.g. the initial-values one which is not in DID Core but still used by various DID implementations).
OR13
approved these changes
Jun 16, 2020
msporny
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the DID parameter table copied from DID Core. Instead, each DID parameter is added as its own subsection, with references to the DID Core section where the parameters are defined, plus examples.
Preview | Diff