-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should "id" be mandatory for "service" and "publicKey"? #47
Comments
We should be careful not to bias expressing services based on whether or not people are using DID URLs to refer to them. Just because some services may benefit from being referenced via a DID URL, others may not -- and for those services, IDs may be an unnecessary burden. |
The key ID should be expressed using the JWK "kid" field and not duplicated elsewhere. |
My rationale for raising this PR were considerations around how DID methods work internally. There are some good opinions and usage patterns on the use of IDs (e.g. about fragment immutability - see w3c-ccg/did-spec#238), but ultimately it's up to the DID method how IDs work.
I think all of the above should be supported by the spec. |
I agree with @peacekeeper and we should keep things as they are now (I believe IDs are presently optional) and just make sure the spec is clear on this matter. If it turns out that we have consensus from the group on this, then we should also close issue #46 once this issue is closed. |
No the spec says each public key and service endpoint MUST include |
I don't have a strong opinion about the issue in the broader context of all DID methods. However, |
@selfissued with regard to using JWK as a public key format (which may be a longer discussion, see #67), I believe making In any case, I think if we agree in principle that |
* Make "id" optional for services and public keys. * Change MAY to SHOULD for public keys. * Change MAY to SHOULD for service endpoints. * Say "multiple" instead of "duplicate" entries. * Apply suggestion from @msporny. * Add comment about producing an error. * Address feedback at #66 (comment).
@peacekeeper moved from CCG (w3c-ccg/did-spec#247)
The text was updated successfully, but these errors were encountered: