Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove matrix parameters, addresses #159. #285

Merged
merged 1 commit into from
May 29, 2020
Merged

Remove matrix parameters, addresses #159. #285

merged 1 commit into from
May 29, 2020

Conversation

peacekeeper
Copy link
Contributor

@peacekeeper peacekeeper commented May 14, 2020 •
edited by pr-preview bot
Loading

@peacekeeper
Copy link
Contributor Author

As discussed in #159, and based on the resolution in the 2020-04-07 WG meeting (see minutes).

@peacekeeper peacekeeper requested a review from talltree May 14, 2020 20:15
@peacekeeper peacekeeper linked an issue May 14, 2020 that may be closed by this pull request
Remove matrix parameters from the DID specification #159
Closed
OR13
OR13 reviewed May 14, 2020
View reviewed changes
@peacekeeper peacekeeper marked this pull request as ready for review May 14, 2020 21:49
talltree
talltree approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@talltree talltree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Markus. I agree with defining did-query so that it enforces a specific query parameter syntax.

msporny
msporny approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@msporny msporny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to wait a few more days for people to review this PR before merging it since the group spent so much time discussing it.

@msporny
Copy link
Member

msporny commented May 29, 2020

Normative, debated heavily with consensus reached, multiple positive reviews, merging.

@msporny msporny merged commit ecbc5fa into master May 29, 2020
@msporny msporny deleted the remove-matrix-parameters branch July 3, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OR13 OR13 OR13 left review comments

@msporny msporny msporny approved these changes

@talltree talltree talltree approved these changes

@kdenhartog kdenhartog kdenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove matrix parameters from the DID specification
5 participants
@peacekeeper @msporny @talltree @OR13 @kdenhartog