Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normative statements: Conformance section #426

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

rhiaro
Copy link
Member

@rhiaro rhiaro commented Oct 3, 2020

Removes untestable normative language from Conformance section, towards #384


Preview | Diff

Copy link
Member

@brentzundel brentzundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits, otherwise LTGM

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as long as the changes that @brentzundel requested are made.

Copy link
Contributor

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this with @brentzundel 's suggestions.

@msporny
Copy link
Member

msporny commented Oct 12, 2020

@rhiaro waiting on you to merge @brentzundel's changes to make sure you're ok with them.

@rhiaro rhiaro force-pushed the rhiaro-384-normative-statements-conformance branch from 94a3871 to d3d5772 Compare October 18, 2020 16:00
@rhiaro rhiaro requested a review from msporny October 18, 2020 18:12
Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @brentzundel suggestions have been merged now as well

@msporny
Copy link
Member

msporny commented Oct 26, 2020

Normative, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 6026da8 into master Oct 26, 2020
@msporny msporny deleted the rhiaro-384-normative-statements-conformance branch November 8, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants