Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normative statements: Identifier section #427

Merged
merged 7 commits into from
Oct 27, 2020

Conversation

rhiaro
Copy link
Member

@rhiaro rhiaro commented Oct 3, 2020

Reorganises normative language in Identifier section, towards #384


Preview | Diff

@msporny
Copy link
Member

msporny commented Oct 8, 2020

Merge conflicts, please rebase.

Copy link
Contributor

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, I had two inline comments.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@msporny
Copy link
Member

msporny commented Oct 12, 2020

@rhiaro waiting on you to address merge conflicts and address @peacekeeper and @iherman's comments.

@rhiaro rhiaro force-pushed the rhiaro-384-normative-statements-identifier branch from d782779 to eab2e4f Compare October 18, 2020 17:58
@msporny
Copy link
Member

msporny commented Oct 26, 2020

@rhiaro -- merge conflicts, please fix.

@rhiaro rhiaro force-pushed the rhiaro-384-normative-statements-identifier branch from e32948a to 74586e8 Compare October 26, 2020 15:07
@rhiaro
Copy link
Member Author

rhiaro commented Oct 26, 2020

Rebased and fixed conflicts

@msporny
Copy link
Member

msporny commented Oct 27, 2020

Normative, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 5dd10b5 into master Oct 27, 2020
@msporny msporny deleted the rhiaro-384-normative-statements-identifier branch November 8, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants