<span class="a b c">.classList.replace("c", "a") -> "a b" or "b a"? #117

ayg · 2017-04-05T12:04:04Z

The spec just says "Replace token in tokens with newToken", but this doesn't actually work in an ordered set, because if you actually replaced it as instructed, the set would have a duplicate entry. Test-case:

data:text/html,<!doctype html>
<script>
var span = document.createElement("span");
span.setAttribute("class", "a b c");
span.classList.replace("c", "a");
document.documentElement.textContent = span.getAttribute("class");
</script>

Firefox Aurora says "a b". Chrome doesn't seem to support .replace(). I don't have Edge or WebKit handy yet to test.

kkdomono · 2017-04-16T03:14:21Z

I tested with Safari 10.1, it say "a b" too, same as FireFox.

yongsheng · 2017-04-16T03:15:26Z

thanks, @linzhiping . I think we'll add it in DOM4.1. @chaals

@linzhiping will take over this issue.

Changes in Terminology. Add a definition to "ordered set" and clarify the replace operation to make sure the behavior is clear.

1. Define token set using ordered set for DOMTokenList. 2. Refine DOMTokenList's length and indexing. 3. Make DOMTokenList's contains() not throw because it doesn't modify token set. 4. Combine DOMSettableTokenList into DOMTokenList, because DOMTokenList.value could be a stringifier attribute, therefore it is OK to make 'value' a stringifier. 5. Use less loops for DOMTokenList's add() and remove(). 6. Always update a DOMTokenList when invoking toggle(). This shall normalize duplicates and whitespaces even if they're no-ops like add()/remove(). This fixes w3c#118 too. 7. Introduce DOMTokenList's replace(). This shall fix w3c#117 together. 8. Introduce DOMTokenList's supports().

Changes in Terminology. Add a definition to "ordered set" and clarify the replace operation to make sure the behavior is clear.

1. Define token set using ordered set for DOMTokenList. 2. Refine DOMTokenList's length and indexing. 3. Make DOMTokenList's contains() not throw because it doesn't modify token set. 4. Combine DOMSettableTokenList into DOMTokenList, because DOMTokenList.value could be a stringifier attribute, therefore it is OK to make 'value' a stringifier. 5. Use less loops for DOMTokenList's add() and remove(). 6. Always update a DOMTokenList when invoking toggle(). This shall normalize duplicates and whitespaces even if they're no-ops like add()/remove(). This fixes #118 too. 7. Introduce DOMTokenList's replace(). This shall fix #117 together. 8. Introduce DOMTokenList's supports().

zqzhang · 2017-05-19T05:53:13Z

This shall be fixed.

yongsheng added this to the m4 milestone Apr 16, 2017

ayg mentioned this issue Apr 18, 2017

<span class="a b c">.classList.replace("c", "a") -> "a b" or "b a"? (DOMTokenList) whatwg/dom#442

Closed

yongsheng assigned zqzhang May 12, 2017

yongsheng pushed a commit to yongsheng/dom that referenced this issue May 17, 2017

Fix w3c#117: Clarify the replace operation of ordered set.

7ea4fcf

Changes in Terminology. Add a definition to "ordered set" and clarify the replace operation to make sure the behavior is clear.

yongsheng pushed a commit that referenced this issue May 17, 2017

Fix #117: Clarify the replace operation of ordered set.

09b8ac9

Changes in Terminology. Add a definition to "ordered set" and clarify the replace operation to make sure the behavior is clear.

zqzhang closed this as completed May 19, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

<span class="a b c">.classList.replace("c", "a") -> "a b" or "b a"? #117

<span class="a b c">.classList.replace("c", "a") -> "a b" or "b a"? #117

ayg commented Apr 5, 2017

kkdomono commented Apr 16, 2017

yongsheng commented Apr 16, 2017 •

edited

Loading

zqzhang commented May 19, 2017

<span class="a b c">.classList.replace("c", "a") -> "a b" or "b a"? #117

<span class="a b c">.classList.replace("c", "a") -> "a b" or "b a"? #117

Comments

ayg commented Apr 5, 2017

kkdomono commented Apr 16, 2017

yongsheng commented Apr 16, 2017 • edited Loading

zqzhang commented May 19, 2017

yongsheng commented Apr 16, 2017 •

edited

Loading