Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

Mutation algorithms:Replacing a child within parent had the wrong previousSibling in its mutation record #82

Closed
2 tasks done
wucongdonglai opened this issue Jan 10, 2017 · 2 comments
Milestone

Comments

@wucongdonglai
Copy link

wucongdonglai commented Jan 10, 2017

@yongsheng
Copy link
Collaborator

yongsheng commented Jan 18, 2017

Missing one commit:

  • whatwg@c20e4b5 Do not remove child from its parent when replacing a node by itself

@yongsheng
Copy link
Collaborator

yongsheng commented Feb 24, 2017

close this issue since it's related to #25. will change it there.

@yongsheng yongsheng reopened this Apr 15, 2017
@yongsheng yongsheng added this to the m3 milestone May 10, 2017
yongsheng pushed a commit to yongsheng/dom that referenced this issue May 17, 2017
Changed in node
When queue a mutation record in replacing a child with node, the
child has been removed. So we should use var previousSibling
rather than using child's previous sibling.
yongsheng pushed a commit that referenced this issue May 17, 2017
Changed in node
When queue a mutation record in replacing a child with node, the
child has been removed. So we should use var previousSibling
rather than using child's previous sibling.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants