Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed warning on deprecation of respec-w3c-common #1256

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Fixed warning on deprecation of respec-w3c-common #1256

merged 3 commits into from
Sep 23, 2020

Conversation

andrea-perego
Copy link
Contributor

@andrea-perego andrea-perego commented Sep 21, 2020 •
edited
Loading

@andrea-perego andrea-perego added this to the DCAT3 FPWD milestone Sep 21, 2020
@andrea-perego andrea-perego marked this pull request as ready for review September 21, 2020 21:14
@agbeltran agbeltran self-requested a review September 22, 2020 06:48
@agbeltran
Copy link
Member

@andrea-perego comparing this branch (https://raw.githack.com/w3c/dxwg/andrea-perego-fix-respec-w3c-common-warning/dcat/index.html) with master (https://w3c.github.io/dxwg/dcat/) I noticed that the ORCIDs have disappeared for most of us - could this be related with the migration issue?

@andrea-perego
Copy link
Contributor Author

@andrea-perego comparing this branch (https://raw.githack.com/w3c/dxwg/andrea-perego-fix-respec-w3c-common-warning/dcat/index.html) with master (https://w3c.github.io/dxwg/dcat/) I noticed that the ORCIDs have disappeared for most of us - could this be related with the migration issue?

Thanks for spotting this, @agbeltran . Actually, the ORCID link is there, but the (SVG) icon is not loaded for some reasons.

I'll raise this issue in the ReSpec repo. Until it will be fixed, I would keep on hold this PR.

@andrea-perego
Copy link
Contributor Author

I'll raise this issue in the ReSpec repo. [...]

Done: https://github.com/w3c/respec/issues/3129

@andrea-perego
Copy link
Contributor Author

Just fixed https://github.com/w3c/respec/issues/3129#issuecomment-697269370 :

https://raw.githack.com/w3c/dxwg/andrea-perego-fix-respec-w3c-common-warning/dcat/index.html

Unless any of finds other issues, I think we can merge this one.

@riccardoAlbertoni riccardoAlbertoni merged commit b30a896 into gh-pages Sep 23, 2020
@riccardoAlbertoni riccardoAlbertoni deleted the andrea-perego-fix-respec-w3c-common-warning branch September 23, 2020 10:29
@agbeltran
Copy link
Member

all looks good now, thanks @andrea-perego and @riccardoAlbertoni for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardoAlbertoni riccardoAlbertoni riccardoAlbertoni approved these changes

@davebrowning davebrowning Awaiting requested review from davebrowning

@dr-shorthair dr-shorthair Awaiting requested review from dr-shorthair

@pwin pwin Awaiting requested review from pwin

@agbeltran agbeltran Awaiting requested review from agbeltran

Assignees
No one assigned
Labels
dcat Editorial
Projects
None yet
Milestone
DCAT3 FPWD
Development

Successfully merging this pull request may close these issues.
3 participants
@andrea-perego @agbeltran @riccardoAlbertoni