Inclujde PaintMixin in PerformanceElementTiming
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given w3c/paint-timing#62, we now expose paint timestamps as part of PaintTimingMixin. This PR extends PerformanceElementTiming to include that mixin and propagates the right calls.
|
@clelland can you review please? |
noamr
changed the title
PaintMixinPaintMixin in PerformanceElementTiming
clelland
approved these changes
Nov 13, 2024
| Due to the difficulty in obtaining this information today, we choose not to expose the display timestamp for images that fail the <a>timing allow check</a>. | ||
| For clarity, here is a code snippet using the PaintTiming API: | ||
| The {{renderTime}} (display timestamp) is indeed newly exposed information. Implementations are advised to coarsen that timestamp further, | ||
| o a 4 milliseconds resolution at least, to avoid exposing differences in decoding time between cross-origin images. Note that other checks, |
There was a problem hiding this comment.
Typo at the beginning of the line should be "to a 4 millisecond resolution..."
|
@clelland can you merge please? I don't have write access to this repo. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
paintTimingandpresentationTimeinPerformanceElementTimingthroughPaintMixinPreview | Diff