Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letting users override CSS "as desired" is unclear #1605

Closed
dlazin opened this issue Apr 2, 2021 · 3 comments · Fixed by #1620
Closed

Letting users override CSS "as desired" is unclear #1605

dlazin opened this issue Apr 2, 2021 · 3 comments · Fixed by #1620
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation Status-Proposed Solution A proposed solution has been included in the issue for working group review

Comments

@dlazin
Copy link
Contributor

dlazin commented Apr 2, 2021

https://w3c.github.io/epub-specs/epub33/rs/#confreq-css-user-styles says It SHOULD allow users to override the EPUB Creator's style sheets as desired.

First, SHOULD seems too aggressive here. If an RS doesn't want to, isn't that an OK decision? I recommend dropping to MAY.

Secondly, "as desired" suggests letting users upload their own stylesheets, or at least suggests nothing in particular. I think we mean "should let users change font size, dark mode, and maybe a couple other things like line-spacing or paragraph justification."

At most, that handful of options should (maybe) be SHOULD, and most other properties SHOULD NOT be user-overrideable; it's way too hard for a publisher to ensure their book won't break if users can override arbitrary (or just different) properties in different RSes.

Can we consider dropping to MAY, and rephrase "as desired" to be more specific, possibly adding a list of SHOULD NOTs?

@Doktorchen
Copy link

If a user changes much more than font-size, this user takes the control over the complete style sheet results.

It would have been a good idea to require by CSS already
a) authors to switch off user-agent stylesheets
b) users to switch off user-agent stylesheets and author stylesheets

Currrently for EPUB it is in practice more a problem, that several user-agents do not respect the priorities of author-stylesheets resulting in nonsens-displays, if everything is mixed up.
And different from users authors have no control, which user-agent is used, therefore no chance to care about such problems.

@mattgarrish mattgarrish added the Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation label Apr 5, 2021
@iherman
Copy link
Member

iherman commented Apr 6, 2021

What about something like:

It MAY override the EPUB Creator's style sheet as a result of user interaction.

This means that the possibility of simply "upload" a style sheet is not present, and that the control is in the interactive possibilities offered by the RS. Ie, at the end of the day, it is the RS's responsibility to decide which part of the Creator's CSS is really overwritten.

@iherman iherman added the Status-Proposed Solution A proposed solution has been included in the issue for working group review label Apr 6, 2021
@dlazin
Copy link
Contributor Author

dlazin commented Apr 6, 2021

That looks good to me, or maybe better "It MAY override parts of the EPUB Creator's style sheet as a result of user interaction." That makes clear that we're not talking about discarding the whole style sheet.

@mattgarrish mattgarrish added the EPUB33 Issues addressed in the EPUB 3.3 revision label May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation Status-Proposed Solution A proposed solution has been included in the issue for working group review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants