Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User interaction may overwrite CSS #1620

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

iherman
Copy link
Member

@iherman iherman commented Apr 7, 2021

Fix #1605

The only change is using the sentence in #1605 (comment)

@iherman iherman requested review from dlazin and mattgarrish April 7, 2021 10:15
@iherman iherman added the Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation label Apr 7, 2021
@mattgarrish mattgarrish requested a review from dauwhe April 7, 2021 13:44
@mattgarrish
Copy link
Member

I agree with the initial lack of clarity about what this bullet is requiring of reading systems, but we're losing the
recommendation that reading systems provide user control over styling in the rewrite. From an accessibility perspective, that's a very important thing to have.

But maybe if we have to write an (informative) accessibility section in this document per #1608 it can go there.

I'll take a skim through the html spec and see if they touch on this at all.

Copy link
Contributor

@dlazin dlazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattgarrish
Copy link
Member

I couldn't find anything in the HTML or CSS specs. Only UAAG goes into this a bit, but even it's pretty vague. Short of mandating the control a user has to have, the language we had was about as good as you can get.

I'm going to take this up when I get to the accessibility section instead.

@mattgarrish mattgarrish merged commit 75557bc into main Apr 8, 2021
@mattgarrish mattgarrish deleted the editorial/CSS-override-issue-1605 branch April 8, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Letting users override CSS "as desired" is unclear
3 participants