Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove requirement to support SVG requiredExtensions attribute per #1087 #1662

Merged
merged 2 commits into from
May 4, 2021

Conversation

dauwhe
Copy link
Contributor

@dauwhe dauwhe commented May 4, 2021

@dauwhe dauwhe requested review from iherman and mattgarrish May 4, 2021 15:25
@iherman iherman self-requested a review May 4, 2021 16:32
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change should be recorded in the changes' section.

@mattgarrish
Copy link
Member

mattgarrish commented May 4, 2021

Fine with this change (except needs a change entry as already noted), but are authors still required to set the attribute or are we dropping that requirement, too?

@iherman
Copy link
Member

iherman commented May 4, 2021

Fine with this change (except needs a change entry as already noted), but are authors still required to set the attribute or are we dropping that requirement, too?

Looking up the original issues it seems that this attribute does more harm than good; my own tests resulted in SVG content that was not displayed (eg, on Thorium). So yes, I believe authors should forget about this.

@dauwhe
Copy link
Contributor Author

dauwhe commented May 4, 2021

I removed the corresponding line from the core spec, and added an entry to the change log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants