-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the custom attribute sections #1756
Conversation
add note about rs-specific nature of the attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wonder whether, for reasons of symmetry, we should not make a similar section (or factor out a common section) for SVG, too. After all, an RS may decide to have a RS-specific attribute in SVG content, too.
(I realize this is probably a technical purity issue of the spec rather than reflecting real usage out there, so I am o.k. if you decide to ignore this...)
We don't have this issue with SVG: https://www.w3.org/TR/SVG2/struct.html#ForeignNamespaces HTML is more restrictive, so we had to explicitly allow foreign attributes. |
I guess we should wait on a formal WG nod before merging this one, since it's undoing an earlier resolution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be more clear about what a custom attribute is (it's not quite a standard term in HTML). As far as I can tell, what EPUB has historically allowed is attributes in namespaces other than xhtml
or epub
. Just adding a foo
attribute won't validate.
The proposed text says:
For me, that makes it explicit that just |
Ah, I guess I hope there would be some explanation about the namespaces in the authoring spec as well as the reading system spec. I fear content authors will see this as a license to use |
The issue was discussed in a meeting on 2021-08-13 List of resolutions:
View the transcript3. Custom AttributesSee github pull request #1756. Dave Cramer: we took out the custom attributes section, but it turns out there are RS that use these Dan Lazin: can we get some documentation on what exists in terms of custom attributes? So people can make use of them in their books? Dave Cramer: we can see about including some examples
Dave Cramer: okay, thanks everyone! |
@dauwhe I do not think the normative statements should be changed. But I have added an extra note right after the list of domains, as follows:
|
@dauwhe are you o.k. with #1756 (comment)? We could then close this PR |
Also adds @iherman's suggested text about rs-specific nature of the attributes. I've made this a note, though, as it's more describing future process.
Only other change was to use "domain" instead of "authority component" in the part about the restricted strings so we can reference the URL standard instead of RFC3186.
Fixes #1602
Preview | Diff