Require links to all reproduced pages in page list #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the page list to a requirement
mattgarrish
requested review from
gregoriopellegrino,
GeorgeKerscher,
clapierre and
avneeshsingh
clapierre
approved these changes
Apr 8, 2022
|
I understand, but I'm not sure that being strict is okay. For one thing: it's very hard to test automatically, for another there might be situations (e.g. remediation of old EPUB 2 into accessible EPUB 3) where generating a complete page list might be almost impossible, while inserting a partial one (e.g. based on TOC) might be easier. Finally, page-markers are optional, but without page-markers in a reflowable EPUB it is almost impossible to have a complete pagelist. I think we discussed it here: #1471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2220