-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dockerfile and a guide to build using docker #1127
Conversation
Sorry for the late reaction on this PR 😅, and thanks @novalagung for the contribution 😊. I'm not super familiar with docker best practices (is it a common practice to push docker files in git repos?), so I'll need to spend the time to read more or get external advice before merging this. Also, I noticed that you also pushed a Docker image for EPUBCheck on Docker Hub. This looks useful! With this image available on the hub, is it still useful to have a docker file in the repo? Ideally we would need to setup a travis build step or GitHub action to automatically push new docker images for tagged builds… I'm marking this PR as "needs review" for now! |
hi @rdeltour thank you for the response.
Yes, it is. by including the docker file to the git repo, it'll be easier for anyone to perform build and run the epubcheck source code. Let's try to use this epubcheck as an example. Right after cloning the repo, to be able to run the project I have to ensure JDK is installed locally, maven as well, etc. it's not a big deal for anyone who already has everything ready in their environment. but for me who rarely code java, I have to set up a lot of things first. By putting the docker file into the project, it'll make us easier to build and run the project. meaning I don't have to set up a lot of things, so the only docker is enough. I just need to run
Yes, I did push it to my docker hub. Anyone can use that docker image to run epubcheck without the need to rebuild the source code first, so simply just run However, I would say that putting the docker file into the project is still mandatory because to be able to build the image we need the docker file. especially if there is a plan to enable automatic push to the Docker hub, the build process will require the docker file ready.
I think so. It'll be better if epubcheck has an official docker hub image, and then the automatic update is enabled via Travis (or other CI/CD tools). |
Thanks for the info @novalagung, that's very useful! 👍 |
In addition, it would be great if there was a simple REST API for epubcheck. That, along with Docker, would enable us to run it as a microservice in our environment. |
Merged in as d0ed6a4. Thanks again @novalagung! |
this pr contains two things:
dockerizing epubcheck will make installation and execution easier, especially for anyone who doesn't have the java dependencies ready in their local computer