Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gyroscope can use the screen local coordinates #28

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

pozdnyakov
Copy link

@pozdnyakov pozdnyakov commented Feb 6, 2018

The SpatialSensorOptions dictionary and the
"construct spatial sensor object" are used, so that
the client can set the local coordinate system for a
Gyroscope instance from the constructor.

This patch is a part of fix for w3c/sensors#257


Preview | Diff

@pozdnyakov
Copy link
Author

@alexshalamov @anssiko PTAL

Copy link

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe change 'is expressed in' to 'is defined with' or 'is defined by' a [=local coordinate system=]

The `SpatialSensorOptions` dictionary and the
"construct spatial sensor object" are used, so that
the client can set the local coordinate system for a
Gyroscope instance from the constructor.

This patch is a part of fix for w3c/sensors#257
@pozdnyakov pozdnyakov merged commit e7c89b0 into w3c:gh-pages Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants