Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "global monotonic clock" to "shared" and expose new algorithm "unsafe shared current time" #107

Merged
merged 6 commits into from
Mar 4, 2021
Merged

Change "global monotonic clock" to "shared" and expose new algorithm "unsafe shared current time" #107

merged 6 commits into from
Mar 4, 2021

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 3, 2021 •
edited by pr-preview bot
Loading

"global" is a term already used to describe the global
object, while this monotonic clock is shared across globals
(e.g. workers and the window).

Also expose "unsafe shared current time", for use by Fetch.
See whatwg/fetch#1185

Closes #99

Preview | Diff

@noamr
Change "global monotonic clock" to "universal"
8ab4d69 
"global" is a term already used to describe the global
object, while this monotonic clock is shared across globals
(e.g. workers and the window).

Also expose "current universal time", for use by Fetch.
See whatwg/fetch#1185
@noamr noamr requested a review from yoavweiss March 3, 2021 08:10
@noamr noamr mentioned this pull request Mar 3, 2021
Merged
yoavweiss
yoavweiss approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want to get more eyes on this to make sure I'm not missing anything.
Also, we want to make sure that "global monotonic clock" is not being used outside of this spec.

@yoavweiss yoavweiss requested a review from npm1 March 3, 2021 08:35
@yoavweiss
Copy link
Contributor

GH search shows that we'd need to update WebAuthn at the very least

yoavweiss
yoavweiss reviewed Mar 3, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
@yoavweiss
Copy link
Contributor

GH search shows that we'd need to update WebAuthn at the very least

Looking closer, this is not really being used there, so unexporting LGTM

@noamr noamr changed the title Change "global monotonic clock" to "universal" Change "global monotonic clock" to "shared" Mar 3, 2021
@noamr noamr changed the title Change "global monotonic clock" to "shared" Change "global monotonic clock" to "shared" and expose new algorithm "unsafe shared current time" Mar 3, 2021
npm1
npm1 approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix #99?

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@noamr
Copy link
Contributor Author

noamr commented Mar 4, 2021

Does this fix #99?

Seems like it does! Will update the description.

yoavweiss
yoavweiss reviewed Mar 4, 2021
View reviewed changes
index.html Show resolved Hide resolved
@yoavweiss
Copy link
Contributor

Thanks for doing this!! :)

@yoavweiss yoavweiss merged commit 1cbeabe into gh-pages Mar 4, 2021
@yoavweiss yoavweiss deleted the universal-m-clock branch March 4, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

@npm1 npm1 npm1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose "unsafe now" for internal uses
3 participants
@noamr @yoavweiss @npm1