-
Notifications
You must be signed in to change notification settings - Fork 551
Conversation
removed code causing layout issues in example
sections/semantics-forms.include
Outdated
@@ -1209,7 +1209,7 @@ | |||
<pre highlight="html"> | |||
<form> | |||
<table> | |||
<caption>Example <<code>label</code>:gt;'s <code>for</code> attribute with <<code>label</code>></caption> | |||
<caption>Example <label:gt;'s for attribute with <label></caption> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a typo on that line as well as the <code>
tags... So the closing angle backet for the 1st label currently says :gt;
and this should be replaced with >
(just before 's)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a colon after example, and "with label" seems totally redundant.
(Yes, this is nitpicking editorial comment…)
fixed typo
tweaked as per @chaals comments
sections/semantics-forms.include
Outdated
@@ -1209,7 +1209,7 @@ | |||
<pre highlight="html"> | |||
<form> | |||
<table> | |||
<caption>Example <label>'s for attribute with <label></caption> | |||
<caption>Example, <label>'s for attribute</caption> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevefaulkner I think @chaals 's comment was to add a colon, but a comma was added instead... (unless the plan changed as you're in the f2f meeting together?). (btw I hope it is ok for me to comment this way).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agcolom it's great to comment like this.
I did mean a colon, but grammatical nits in the text of code examples are not that important, so I'll merge this and wait for someone else if they want to fix it further…
removed code causing layout issues in example, fixes #831