Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define presentation compositor #61

Merged
merged 4 commits into from
Feb 27, 2023

Conversation

palemieux
Copy link
Contributor

@palemieux palemieux commented Dec 14, 2022

Closes #58


Preview | Diff

@palemieux
Copy link
Contributor Author

@rhiaro See proposed clarification, which should have made finding the meaning of presentation compositor easier.

spec/imsc-hrm.html Outdated Show resolved Hide resolved
@palemieux palemieux requested a review from nigelmegitt January 5, 2023 01:30
@nigelmegitt
Copy link
Contributor

@rhiaro Would this pull request resolve the issue - I think we have likely got consensus for it, at least amongst those who have written and reviewed it.

@palemieux palemieux requested a review from nigelmegitt January 16, 2023 11:48
@nigelmegitt
Copy link
Contributor

I'd prefer to hold off on a review until @rhiaro has commented, at least for a few days.

@css-meeting-bot
Copy link
Member

The Timed Text Working Group just discussed IMSC-HRM PR: Define presentation compositor #61, and agreed to the following:

  • SUMMARY: @nigelmegitt to talk to/ping @rhiaro to unblock this.
The full IRC log of that discussion <nigel> Topic: IMSC-HRM PR: Define presentation compositor #61
<nigel> github: https://github.com//pull/61
<nigel> Nigel: In the context of the previous discussion, it may be that Amy is waiting for
<nigel> .. an answer to the TAG review comment's questions before coming back on this.
<nigel> .. I think we need to leave it as is until we've responded.
<nigel> Pierre: Arguably this is completely editorial, so we should merge.
<nigel> Nigel: It may be - let me try to unblock this by talking, first.
<nigel> Pierre: alright
<nigel> SUMMARY: @nigelmegitt to talk to/ping @rhiaro to unblock this.

@palemieux
Copy link
Contributor Author

@nigelmegitt You apparently need to approve it as well.

@palemieux palemieux merged commit 063a159 into main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define 'Presentation Compositor' [TAG review]
4 participants