Ignore images that take the full page viewport #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few things:
|
yoavweiss
reviewed
Sep 30, 2021
There was a problem hiding this comment.
- Note sure why ipr is complaining?
I suspect that was a glitch. The bots seem to like you now
- The way I used to get the top-level document is a bit convoluted, not sure if there is an easier way
Suggested a simplification, which can work if my assumptions are correct
noamr
added a commit
that referenced
this pull request
Nov 13, 2024
Instead of initializing `renderTime`, take it from the paint timing info as propagated from paint timing. See w3c/paint-timing#62 and wicg/element-timing/#81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73
Preview | Diff