LoAF initial spec #122
Merged
LoAF initial spec #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes part of the long animation frame spec: - Intro - Security & privacy - Some of the attributes It doesn't include yet: - Scripts - desiredRenderStart - firstUIEventTimestamp Note also that it exports a few algorithms to be called from the HTML spec.
This was referenced Nov 22, 2023
yoavweiss
reviewed
Nov 23, 2023
index.bs
Outdated
| readonly attribute DOMString name; | ||
| readonly attribute DOMString entryType; | ||
| readonly attribute DOMHighResTimeStamp startTime; | ||
| readonly attribute DOMHighResTimeStamp duration; |
There was a problem hiding this comment.
You don't need to redefine the attributes that are in PerformanceEntry
index.bs
Outdated
|
|
||
| The {{PerformanceLongAnimationFrameTiming/blockingDuration}} attribute's getter steps are: | ||
|
|
||
| 1. Let |workDuration| be [=this=]'s [=this=]'s [=PerformanceLongAnimationFrameTiming/timing info=]'s [=frame timing info/longest task duration=]. |
index.bs
Outdated
|
|
||
| 1. Let |workDuration| be [=this=]'s [=this=]'s [=PerformanceLongAnimationFrameTiming/timing info=]'s [=frame timing info/longest task duration=]. | ||
| 1. Let |renderDuration| be the 0. | ||
| 1. If [=this=]'s [=PerformanceLongAnimationFrameTiming/timing info=]'s [=frame timing info=/update the rendering start time=] is not zero, then: |
index.bs
Outdated
| :: A {{DOMHighResTimeStamp}}, initially 0. | ||
| </dl> | ||
|
|
||
| A {{Document}} has a null-or-[=frame timing info=] <dfn>current frame timing info</dfn>, initially null. |
There was a problem hiding this comment.
Can we just append a "null-or-" to random structs without defining the whole thing?
There was a problem hiding this comment.
It seems like your defining a new type named "null-or-frame timing info". But I see a similar pattern in Fetch, only without the "-". Maybe drop them?
index.bs
Outdated
| </div> | ||
|
|
||
| <div algorithm="Report task start time"> | ||
| To <dfn export>report task start time</dfn> given an {{DOMHighResTimeStamp}} |taskStartTime|, and a {{Document}} |document|: |
index.bs
Outdated
| 1. If |root|'s [=current frame timing info=] is null, | ||
| then set |root|'s [=current frame timing info=] to a new [=frame timing info=] whose [=frame timing info/start time=] is |taskStartTime|. | ||
|
|
||
| 1. Set |timingInfo|'s [=current frame timing info=]'s [=frame timing info/current task start time=] to |taskStartTime|. |
There was a problem hiding this comment.
What's |timingInfo| here?
index.bs
Outdated
| </div> | ||
|
|
||
| <div algorithm="Queue frame timing"> | ||
| To <dfn export>flush frame timing</dfn> given a {{Document}} |document| and a {{DOMHighResTimeStamp}} |endTime|: |
There was a problem hiding this comment.
Generally, it might be better to prefix all the unsafe timestamps with "unsafe" (or something similar), rather than prefixing the safe ones.
yoavweiss
approved these changes
Nov 24, 2023
index.bs
Outdated
| :: A {{DOMHighResTimeStamp}}, initially 0. | ||
| </dl> | ||
|
|
||
| A {{Document}} has a null-or-[=frame timing info=] <dfn>current frame timing info</dfn>, initially null. |
There was a problem hiding this comment.
It seems like your defining a new type named "null-or-frame timing info". But I see a similar pattern in Fetch, only without the "-". Maybe drop them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes part of the long animation frame spec:
It doesn't include yet:
Note also that it exports a few algorithms to be called from the HTML spec.
Preview | Diff