LoAF: Amend blockingDuration to match implementation
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`blockingDuration` is a total duration of all the blocking part (anything above the first 50ms) tasks that contributed to the LoAF. The rendering duration is considered as part of the longest task.
|
@mmocny this is what we originally agreed about re |
mmocny
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
This is great, LGTM.
I think the one question I have is that the algorithm depends on the definition of update-the-rendering-start-time and at least from Chromium I know that there was some question about which work can or cannot sneak in. I suspect that is beyond scope for this since its really about the event loop / update-the-rendering steps themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blockingDurationis a total duration of all the blocking part (anything above the first 50ms) tasks that contributed to the LoAF. The rendering duration is considered as part of the longest task.Preview | Diff