Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames: use invoker/invokerType instead of name/type #129

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Renames: use invoker/invokerType instead of name/type #129

merged 1 commit into from
Jan 12, 2024

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Jan 12, 2024 •
edited by pr-preview bot
Loading

@noamr noamr requested a review from clelland January 12, 2024 09:58
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 12, 2024
@noamr @chromium-wpt-export-bot
LoAF: Rename name to invoker and type to invokerType
0eeb857 
As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jan 12, 2024
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 12, 2024
@noamr @chromium-wpt-export-bot
LoAF: Rename name to invoker and type to invokerType
4a0059b 
As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
clelland
clelland approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@clelland clelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 12, 2024
@noamr @chromium-wpt-export-bot
LoAF: Rename name to invoker and type to invokerType
f0db35f 
As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
@noamr noamr merged commit 9fe9106 into main Jan 12, 2024
3 checks passed
@noamr noamr deleted the invoker branch January 12, 2024 15:19
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 12, 2024
@noamr @chromium-wpt-export-bot
LoAF: Rename name to invoker and type to invokerType
a52e647 
As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 12, 2024
@noamr
LoAF: Rename name to invoker and type to invokerType
0dbde43 
As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189280
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1246482}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 12, 2024
@noamr @chromium-wpt-export-bot
LoAF: Rename name to invoker and type to invokerType
7571a50 
As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189280
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1246482}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 12, 2024
@noamr @chromium-wpt-export-bot
LoAF: Rename name to invoker and type to invokerType
28da38f 
As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189280
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1246482}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 15, 2024
@noamr @moz-wptsync-bot
Bug 1874391 [wpt PR 43967] - LoAF: Rename name to invoker and `ty…
aa15faf 
…pe` to `invokerType`, a=testonly

Automatic update from web-platform-tests
LoAF: Rename `name` to `invoker` and `type` to `invokerType`

As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189280
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1246482}

--

wpt-commits: 28da38f0eaa3da71555880eff371485d8a6465b6
wpt-pr: 43967
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Jan 16, 2024
@marco-c
Bug 1874391 [wpt PR 43967] - LoAF: Rename name to invoker and `ty…
e001495 
…pe` to `invokerType`, a=testonly

Automatic update from web-platform-tests
LoAF: Rename `name` to `invoker` and `type` to `invokerType`

As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189280
Reviewed-by: Ian Clelland <iclellandchromium.org>
Commit-Queue: Noam Rosenthal <nrosenthalchromium.org>
Cr-Commit-Position: refs/heads/main{#1246482}

--

wpt-commits: 28da38f0eaa3da71555880eff371485d8a6465b6
wpt-pr: 43967

UltraBlame original commit: 44dbb9c5262945dcd4119b4389b20e81466d7482
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Jan 16, 2024
@marco-c
Bug 1874391 [wpt PR 43967] - LoAF: Rename name to invoker and `ty…
ff3e79c 
…pe` to `invokerType`, a=testonly

Automatic update from web-platform-tests
LoAF: Rename `name` to `invoker` and `type` to `invokerType`

As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189280
Reviewed-by: Ian Clelland <iclellandchromium.org>
Commit-Queue: Noam Rosenthal <nrosenthalchromium.org>
Cr-Commit-Position: refs/heads/main{#1246482}

--

wpt-commits: 28da38f0eaa3da71555880eff371485d8a6465b6
wpt-pr: 43967

UltraBlame original commit: 44dbb9c5262945dcd4119b4389b20e81466d7482
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jan 16, 2024
@marco-c
Bug 1874391 [wpt PR 43967] - LoAF: Rename name to invoker and `ty…
43be62c 
…pe` to `invokerType`, a=testonly

Automatic update from web-platform-tests
LoAF: Rename `name` to `invoker` and `type` to `invokerType`

As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189280
Reviewed-by: Ian Clelland <iclellandchromium.org>
Commit-Queue: Noam Rosenthal <nrosenthalchromium.org>
Cr-Commit-Position: refs/heads/main{#1246482}

--

wpt-commits: 28da38f0eaa3da71555880eff371485d8a6465b6
wpt-pr: 43967

UltraBlame original commit: 44dbb9c5262945dcd4119b4389b20e81466d7482
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Jan 19, 2024
@noamr @moz-wptsync-bot
Bug 1874391 [wpt PR 43967] - LoAF: Rename name to invoker and `ty…
66d4946 
…pe` to `invokerType`, a=testonly

Automatic update from web-platform-tests
LoAF: Rename `name` to `invoker` and `type` to `invokerType`

As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189280
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1246482}

--

wpt-commits: 28da38f0eaa3da71555880eff371485d8a6465b6
wpt-pr: 43967
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 23, 2024
@noamr @marcoscaceres
LoAF: Rename name to invoker and type to invokerType
a34e0b6 
As per w3c/longtasks#129

Bug: 1392685
Change-Id: Ia60e28c7caf27224b3dcab125480555680486155
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189280
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1246482}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clelland clelland clelland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LoAF] Settle on what PerformanceScriptTiming.name means
2 participants
@noamr @clelland