-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add video conferencing actions to the spec #269
Add video conferencing actions to the spec #269
Conversation
Co-authored-by: Tom Jenkinson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
@@ -541,6 +553,14 @@ conforming IDL fragments, as described in the Web IDL specification. [[!WEBIDL]] | |||
provided for the <a>active media session</a>. | |||
</p> | |||
|
|||
<p> | |||
A user agent MAY implement a default handler for the <a enum-value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the default handler for those actions? Especially for hangup, would we call stop() for each MediaStreamTrack? That seems odd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jernoble @eric-carlson May you be able to share what you're thinking of regarding default action handlers for these video conferencing actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jernoble @eric-carlson May you be able to share what you're thinking of regarding default action handlers for these video conferencing actions?
I assume we'll do the same thing that happens now when a user clicks on the capture indicator in the Safari Chrome or menu bar - stop the capture device(s), and set the muted state of each track.
@mounirlamouri Can you review this PR as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mounirlamouri Please merge |
This PR adds the new video conferencing actions as discussed in issue 264
Preview | Diff